[Logstash] allow array values for extra #1450

dmarcs · 2021-11-22T00:17:18Z

Chart version not bumped (the versions are all bumped and released at the same time)
README.md updated with any new values or changes
Updated template tests in ${CHART}/tests/*.py
Updated integration tests in ${CHART}/examples/*/test/goss.yaml

According to https://github.com/elastic/helm-charts/blob/main/logstash/values.yaml this should work

extraVolumes:
  - name: extras
     emptyDir: {}

extraVolumeMounts:
  - name: extras
     mountPath: /usr/share/extras
     readOnly: true

but I get this error when I run helm install

Error: template: charts/logstash/templates/statefulset.yaml:143:14: executing "charts/logstash/templates/statefulset.yaml" at <.Values.extraVolumes>: wrong type for value; expected string; got []interface {}

Fix #1451

elasticmachine · 2021-11-22T00:17:20Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

elasticmachine · 2021-11-22T00:17:20Z

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

tonymayflower · 2021-11-24T10:08:14Z

same issue ..

tonymayflower · 2021-11-24T10:11:11Z

looks the issue is solved in the conversation : #1182

botelastic · 2022-02-22T11:08:03Z

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. To track this PR (even if closed), please open a corresponding issue if one does not already exist.

jmlrt

LGTM⛴

jmlrt · 2022-02-24T14:28:56Z

ok to test

…-values-error

jmlrt · 2022-02-24T16:59:05Z

ok to test

jmlrt · 2022-02-24T17:29:06Z

ok to test

* allow array values for extra * add some tests * fixup! add some tests Co-authored-by: jmlrt <8582351+jmlrt@users.noreply.github.com>

* allow array values for extra * add some tests * fixup! add some tests Co-authored-by: jmlrt <8582351+jmlrt@users.noreply.github.com> Co-authored-by: David Marcus <marcusdavid127@gmail.com>

@jmlrt

* 7.17.1 as default version. | PR | Author | Title | |-----------------------------------------------------------|----------------------------------------------|-------------------------------------------------------------------------| | [elastic#1604](elastic#1604) | [@jmlrt](https://github.com/jmlrt) | [meta] update docker images | | [elastic#1603](elastic#1603) | [@jmlrt](https://github.com/jmlrt) | [metricbeat] add missing rolebinding and cluster role rules | | [elastic#1602](elastic#1602) | [@jmlrt](https://github.com/jmlrt) | [filebeat] add missing rolebinding and cluster role rules | | [elastic#1593](elastic#1593) | [@jmlrt](https://github.com/jmlrt) | [meta] add support for k8s 1.22 | | [elastic#1582](elastic#1582) | [@jmlrt](https://github.com/jmlrt) | [kibana] fix extra values default values | | [elastic#1581](elastic#1581) | [@jmlrt](https://github.com/jmlrt) | [logstash] fix ServiceAccount inconsistencies | | [elastic#1580](elastic#1580) | [@jmlrt](https://github.com/jmlrt) | [elasticsearch] fix ServiceAccount inconsistencies | | [elastic#1570](elastic#1570) | [@jmlrt](https://github.com/jmlrt) | [logstash] add externalTrafficPolicy support | | [elastic#1569](elastic#1569) | [@jmlrt](https://github.com/jmlrt) | [logstash] add flexible ingress | | [elastic#1563](elastic#1563) | [@jmlrt](https://github.com/jmlrt) | [meta] bump Helm version to 3.8.0 | | [elastic#1538](elastic#1538) | [@chetanv-oi](https://github.com/chetanv-oi) | [elasticsearch] move the yaml separator inside the condition | | [elastic#1530](elastic#1530) | [@jmlrt](https://github.com/jmlrt) | [kibana] use bash for readiness script | | [elastic#1527](elastic#1527) | [@ebuildy](https://github.com/ebuildy) | [apm-server] add pod labels | | [elastic#1524](elastic#1524) | [@beatkind](https://github.com/beatkind) | [metricbeat] bump kube-state-metrics to version 4.7.0 | | [elastic#1521](elastic#1521) | [@ebuildy](https://github.com/ebuildy) | [apm-server] fix podLabels | | [elastic#1494](elastic#1494) | [@ebuildy](https://github.com/ebuildy) | [elasticsearch] add keystore container securityContext | | [elastic#1450](elastic#1450) | [@dmarcs](https://github.com/dmarcs) | [logstash] allow array values for extra | | [elastic#1422](elastic#1422) | [@framsouza](https://github.com/framsouza) | [metricbeat] adding custerRole permissions for leader election | | [elastic#1420](elastic#1420) | [@framsouza](https://github.com/framsouza) | [elasticsearch] [logstash] add support to PodDisruptionBudget policy/v1 | | [elastic#1417](elastic#1417) | [@framsouza](https://github.com/framsouza) | [kibana] add annotations at deployment level |

@jmlrt

* 7.17.1 release changelog * 7.17.1 as default version. | PR | Author | Title | |-----------------------------------------------------------|----------------------------------------------|-------------------------------------------------------------------------| | [#1604](#1604) | [@jmlrt](https://github.com/jmlrt) | [meta] update docker images | | [#1603](#1603) | [@jmlrt](https://github.com/jmlrt) | [metricbeat] add missing rolebinding and cluster role rules | | [#1602](#1602) | [@jmlrt](https://github.com/jmlrt) | [filebeat] add missing rolebinding and cluster role rules | | [#1593](#1593) | [@jmlrt](https://github.com/jmlrt) | [meta] add support for k8s 1.22 | | [#1582](#1582) | [@jmlrt](https://github.com/jmlrt) | [kibana] fix extra values default values | | [#1581](#1581) | [@jmlrt](https://github.com/jmlrt) | [logstash] fix ServiceAccount inconsistencies | | [#1580](#1580) | [@jmlrt](https://github.com/jmlrt) | [elasticsearch] fix ServiceAccount inconsistencies | | [#1570](#1570) | [@jmlrt](https://github.com/jmlrt) | [logstash] add externalTrafficPolicy support | | [#1569](#1569) | [@jmlrt](https://github.com/jmlrt) | [logstash] add flexible ingress | | [#1563](#1563) | [@jmlrt](https://github.com/jmlrt) | [meta] bump Helm version to 3.8.0 | | [#1538](#1538) | [@chetanv-oi](https://github.com/chetanv-oi) | [elasticsearch] move the yaml separator inside the condition | | [#1530](#1530) | [@jmlrt](https://github.com/jmlrt) | [kibana] use bash for readiness script | | [#1527](#1527) | [@ebuildy](https://github.com/ebuildy) | [apm-server] add pod labels | | [#1524](#1524) | [@beatkind](https://github.com/beatkind) | [metricbeat] bump kube-state-metrics to version 4.7.0 | | [#1521](#1521) | [@ebuildy](https://github.com/ebuildy) | [apm-server] fix podLabels | | [#1494](#1494) | [@ebuildy](https://github.com/ebuildy) | [elasticsearch] add keystore container securityContext | | [#1450](#1450) | [@dmarcs](https://github.com/dmarcs) | [logstash] allow array values for extra | | [#1422](#1422) | [@framsouza](https://github.com/framsouza) | [metricbeat] adding custerRole permissions for leader election | | [#1420](#1420) | [@framsouza](https://github.com/framsouza) | [elasticsearch] [logstash] add support to PodDisruptionBudget policy/v1 | | [#1417](#1417) | [@framsouza](https://github.com/framsouza) | [kibana] add annotations at deployment level | * add breaking changes + update all toc instructions * fix breaking change error

@jmlrt

* 7.17.1 release changelog * 7.17.1 as default version. | PR | Author | Title | |-----------------------------------------------------------|----------------------------------------------|-------------------------------------------------------------------------| | [#1604](elastic/helm-charts#1604) | [@jmlrt](https://github.com/jmlrt) | [meta] update docker images | | [#1603](elastic/helm-charts#1603) | [@jmlrt](https://github.com/jmlrt) | [metricbeat] add missing rolebinding and cluster role rules | | [#1602](elastic/helm-charts#1602) | [@jmlrt](https://github.com/jmlrt) | [filebeat] add missing rolebinding and cluster role rules | | [#1593](elastic/helm-charts#1593) | [@jmlrt](https://github.com/jmlrt) | [meta] add support for k8s 1.22 | | [#1582](elastic/helm-charts#1582) | [@jmlrt](https://github.com/jmlrt) | [kibana] fix extra values default values | | [#1581](elastic/helm-charts#1581) | [@jmlrt](https://github.com/jmlrt) | [logstash] fix ServiceAccount inconsistencies | | [#1580](elastic/helm-charts#1580) | [@jmlrt](https://github.com/jmlrt) | [elasticsearch] fix ServiceAccount inconsistencies | | [#1570](elastic/helm-charts#1570) | [@jmlrt](https://github.com/jmlrt) | [logstash] add externalTrafficPolicy support | | [#1569](elastic/helm-charts#1569) | [@jmlrt](https://github.com/jmlrt) | [logstash] add flexible ingress | | [#1563](elastic/helm-charts#1563) | [@jmlrt](https://github.com/jmlrt) | [meta] bump Helm version to 3.8.0 | | [#1538](elastic/helm-charts#1538) | [@chetanv-oi](https://github.com/chetanv-oi) | [elasticsearch] move the yaml separator inside the condition | | [#1530](elastic/helm-charts#1530) | [@jmlrt](https://github.com/jmlrt) | [kibana] use bash for readiness script | | [#1527](elastic/helm-charts#1527) | [@ebuildy](https://github.com/ebuildy) | [apm-server] add pod labels | | [#1524](elastic/helm-charts#1524) | [@beatkind](https://github.com/beatkind) | [metricbeat] bump kube-state-metrics to version 4.7.0 | | [#1521](elastic/helm-charts#1521) | [@ebuildy](https://github.com/ebuildy) | [apm-server] fix podLabels | | [#1494](elastic/helm-charts#1494) | [@ebuildy](https://github.com/ebuildy) | [elasticsearch] add keystore container securityContext | | [#1450](elastic/helm-charts#1450) | [@dmarcs](https://github.com/dmarcs) | [logstash] allow array values for extra | | [#1422](elastic/helm-charts#1422) | [@framsouza](https://github.com/framsouza) | [metricbeat] adding custerRole permissions for leader election | | [#1420](elastic/helm-charts#1420) | [@framsouza](https://github.com/framsouza) | [elasticsearch] [logstash] add support to PodDisruptionBudget policy/v1 | | [#1417](elastic/helm-charts#1417) | [@framsouza](https://github.com/framsouza) | [kibana] add annotations at deployment level | * add breaking changes + update all toc instructions * fix breaking change error

allow array values for extra

ce242d3

dmarcs mentioned this pull request Nov 22, 2021

Allow array values for extra #1451

Closed

botelastic bot added the triage/stale label Feb 22, 2022

jmlrt previously approved these changes Feb 24, 2022

View reviewed changes

botelastic bot removed the triage/stale label Feb 24, 2022

jmlrt added enhancement New feature or request logstash need-backport v7.17.0 labels Feb 24, 2022

jmlrt added 2 commits February 24, 2022 15:57

Merge remote-tracking branch 'origin/main' into bugfix/logstash-extra…

1f22e38

…-values-error

add some tests

20e1169

jmlrt dismissed their stale review via 20e1169 February 24, 2022 16:58

fixup! add some tests

98fbbbb

jmlrt merged commit e9f85ea into elastic:main Feb 24, 2022

jmlrt changed the title ~~allow array values for extra~~ [Logstash] allow array values for extra Mar 1, 2022

jmlrt mentioned this pull request Mar 1, 2022

[7.17] [logstash] allow array values for extra (#1450) #1591

Merged

jmlrt added the backported label Mar 1, 2022

jmlrt added a commit to jmlrt/helm-charts that referenced this pull request Mar 1, 2022

allow array values for extra (elastic#1450)

2b09fdb

* allow array values for extra * add some tests * fixup! add some tests Co-authored-by: jmlrt <8582351+jmlrt@users.noreply.github.com>

jmlrt removed the need-backport label Mar 1, 2022

jmlrt mentioned this pull request Mar 8, 2022

7.17.1 bump #1609

Merged

jmlrt added the v7.17.1 label Mar 8, 2022

jmlrt removed the v7.17.0 label Mar 8, 2022

jmlrt mentioned this pull request Mar 8, 2022

7.17.1 release changelog #1610

Merged

jmlrt mentioned this pull request Apr 21, 2022

7.17.3 bump #1649

Merged

This was referenced Sep 14, 2022

[meta] fix yaml indent #1698

Merged

[meta] follow-up of #1698 #1700

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Logstash] allow array values for extra #1450

[Logstash] allow array values for extra #1450

dmarcs commented Nov 22, 2021 •

edited by jmlrt

Loading

elasticmachine commented Nov 22, 2021

elasticmachine commented Nov 22, 2021

tonymayflower commented Nov 24, 2021

tonymayflower commented Nov 24, 2021

botelastic bot commented Feb 22, 2022

jmlrt left a comment

jmlrt commented Feb 24, 2022

jmlrt commented Feb 24, 2022

jmlrt commented Feb 24, 2022

[Logstash] allow array values for extra #1450

[Logstash] allow array values for extra #1450

Conversation

dmarcs commented Nov 22, 2021 • edited by jmlrt Loading

elasticmachine commented Nov 22, 2021

elasticmachine commented Nov 22, 2021

tonymayflower commented Nov 24, 2021

tonymayflower commented Nov 24, 2021

botelastic bot commented Feb 22, 2022

jmlrt left a comment

Choose a reason for hiding this comment

jmlrt commented Feb 24, 2022

jmlrt commented Feb 24, 2022

jmlrt commented Feb 24, 2022

dmarcs commented Nov 22, 2021 •

edited by jmlrt

Loading