add capability to specify alternalte scheduler #141
Conversation
Signed-off-by: Sathya Balakrishnan <sathya@portworx.com>
|
@Crazybus Hi, could you help review this? Or perhaps assign someone to? |
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
There was a problem hiding this comment.
Could you also add a basic template test to make sure that the templating and whitespacing is working correctly? Something like this should do the trick:
def test_scheduler_name():
r = helm_template('')
spec = r['statefulset'][uname]['spec']['template']['spec']
assert 'schedulerName' not in spec
config = '''
schedulerName: "stork"
'''
r = helm_template(config)
assert r['statefulset'][uname]['spec']['template']['spec']['schedulerName'] == "stork"
elasticsearch/README.md
Outdated
| @@ -100,6 +100,7 @@ helm install --name elasticsearch elastic/elasticsearch --version 7.1.0 --set im | |||
| | `nodeSelector` | Configurable [nodeSelector](https://kubernetes.io/docs/concepts/configuration/assign-pod-node/#nodeselector) so that you can target specific nodes for your Elasticsearch cluster | `{}` | | |||
| | `tolerations` | Configurable [tolerations](https://kubernetes.io/docs/concepts/configuration/taint-and-toleration/) | `[]` | | |||
| | `ingress` | Configurable [ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) to expose the Elasticsearch service. See [`values.yaml`](./values.yaml) for an example | `enabled: false` | | |||
| | `schedulerName` | Name of the alternate scheduler (e.g. stork) | `nil` | | |||
There was a problem hiding this comment.
Could you add a link to https://kubernetes.io/docs/tasks/administer-cluster/configure-multiple-schedulers/#specify-schedulers-for-pods as something like alternate scheduler. Could you also remove the e.g. stork just to make sure that nobody gets confused thinking that it is supported or recommended for this chart.
elasticsearch/values.yaml
Outdated
| @@ -142,6 +142,11 @@ readinessProbe: | |||
| # https://www.elastic.co/guide/en/elasticsearch/reference/current/cluster-health.html#request-params wait_for_status | |||
| clusterHealthCheckParams: "wait_for_status=green&timeout=1s" | |||
|
|
|||
| ## Use an alternate scheduler, e.g. "stork". | |||
There was a problem hiding this comment.
Same comment as above about removing stork as an example.
Signed-off-by: Sathya Balakrishnan <sathya@portworx.com>
|
jenkins test this please |
|
Build is failing due to a linting error: |
|
I think setting it to an empty string is what will make the linter happiest. |
Signed-off-by: Sathya Balakrishnan <sathya@portworx.com>
|
Done |
|
jenkins test this please |
Signed-off-by: Sathya Balakrishnan sathya@portworx.com
${CHART}/tests/*.py${CHART}/examples/*/test/goss.yaml