[Kibana] Add loadbalancerIP to service spec in kibana (#726)

elastic · Jul 16, 2020 · 2eefa30 · 2eefa30
1 parent a77a3c5
commit 2eefa30
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 0 deletions.
diff --git a/kibana/templates/service.yaml b/kibana/templates/service.yaml
@@ -13,6 +13,9 @@ metadata:
 {{- end }}
 spec:
   type: {{ .Values.service.type }}
+{{- if .Values.service.loadBalancerIP }}
+  loadBalancerIP: {{ .Values.service.loadBalancerIP }}
+{{- end }}
 {{- with .Values.service.loadBalancerSourceRanges }}
   loadBalancerSourceRanges:
 {{ toYaml . | indent 4 }}

diff --git a/kibana/tests/kibana_test.py b/kibana/tests/kibana_test.py
@@ -51,6 +51,9 @@ def test_defaults():
     # Make sure that the default 'loadBalancerSourceRanges' list is empty
     assert "loadBalancerSourceRanges" not in r["service"][name]["spec"]
 
+    # Make sure that the default 'loadBalancerIP' string is empty
+    assert "loadBalancerIP" not in r["service"][name]["spec"]
+
 
 def test_overriding_the_elasticsearch_hosts():
     config = """
@@ -615,3 +618,14 @@ def test_setting_fullnameOverride():
         ]
         == "kibana"
     )
+
+
+def test_adding_loadBalancerIP():
+    config = """
+    service:
+      loadBalancerIP: 12.5.11.79
+    """
+
+    r = helm_template(config)
+
+    assert r["service"][name]["spec"]["loadBalancerIP"] == "12.5.11.79"
diff --git a/kibana/values.yaml b/kibana/values.yaml
@@ -95,6 +95,7 @@ updateStrategy:
 
 service:
   type: ClusterIP
+  loadBalancerIP: ""
   port: 5601
   nodePort: ""
   labels: {}