Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiNotificationEvent] Spread className and rest props #6208

Merged
merged 4 commits into from
Sep 6, 2022
Merged

[EuiNotificationEvent] Spread className and rest props #6208

merged 4 commits into from
Sep 6, 2022

Conversation

miukimiu
Copy link
Contributor

@miukimiu miukimiu commented Sep 6, 2022 •
edited
Loading

Summary

Closes #6206. This PR spreads the className and rest props on EuiNotificationEvent

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Added documentation
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • Updated the Figma library counterpart
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6208/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6208/

cee-chen
cee-chen approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@cee-chen cee-chen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great to me!

@miukimiu miukimiu marked this pull request as ready for review September 6, 2022 17:03
@miukimiu miukimiu merged commit b2f86e0 into elastic:main Sep 6, 2022
@breehall breehall mentioned this pull request Sep 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[EuiNotificationEvent] Can't set className in EuiNotificationEvent component
3 participants
@miukimiu @kibanamachine @cee-chen