Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Convert EuiListGroup #6207

Merged
merged 40 commits into from
Sep 21, 2022
Merged

Commits on Sep 5, 2022

  1. Configuration menu
    Copy the full SHA
    b02e168 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7164bc7 View commit details
    Browse the repository at this point in the history

Commits on Sep 6, 2022

  1. Configuration menu
    Copy the full SHA
    93d5433 View commit details
    Browse the repository at this point in the history

Commits on Sep 7, 2022

  1. Configuration menu
    Copy the full SHA
    10a3b8f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0ff3a06 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1fad37b View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2022

  1. Configuration menu
    Copy the full SHA
    92135e6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bb45f94 View commit details
    Browse the repository at this point in the history

Commits on Sep 9, 2022

  1. Configuration menu
    Copy the full SHA
    1c168b6 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2022

  1. Configuration menu
    Copy the full SHA
    2304ec2 View commit details
    Browse the repository at this point in the history

Commits on Sep 13, 2022

  1. Added new CL entry

    miukimiu committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    115a08b View commit details
    Browse the repository at this point in the history
  2. Added list group inner

    miukimiu committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    8375cb1 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a3b18ed View commit details
    Browse the repository at this point in the history
  4. Adding alwaysShow

    miukimiu committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    2aa9ad1 View commit details
    Browse the repository at this point in the history
  5. Custom color in last example

    miukimiu committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    c08bacb View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f476e97 View commit details
    Browse the repository at this point in the history
  7. Reverting class names in use

    miukimiu committed Sep 13, 2022
    Configuration menu
    Copy the full SHA
    385117c View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2022

  1. CL

    miukimiu committed Sep 14, 2022
    Configuration menu
    Copy the full SHA
    99d699d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2022

  1. Configuration menu
    Copy the full SHA
    c9cedf9 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2022

  1. Configuration menu
    Copy the full SHA
    6ab15cd View commit details
    Browse the repository at this point in the history
  2. [PR feedback ] misc test/css tweaks

    - make `css` merging as top-level prop and as iconProps work correctly
    
    - add requiredProps to basic renders test
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    9452c15 View commit details
    Browse the repository at this point in the history
  3. [PR feedback] Remove unnecessary euiListGroupItemInnerStyles args i…

    …n favor of array logic
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    1f3261f View commit details
    Browse the repository at this point in the history
  4. [PR feedback] Remove euiListGroupItemStyles in favor of array condi…

    …tionals & obj keys
    
    + DRY out repeated euiBackgroundColor() calls
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    5674a7a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ae3daf2 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    e0398b3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    cb864e2 View commit details
    Browse the repository at this point in the history
  8. [EuiListGroupItemExtraAction] Export props type and document more cle…

    …arly in props table
    
    + move alwayShow to top of props list
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    b5b656b View commit details
    Browse the repository at this point in the history
  9. [EuiListGroupItemExtraAction] Fix non-working hover/focus CSS selectors

    - `.euiListGroupItem-isDisabled` is no longer a className, so the :not() selector is not working and the action still appears on hover on disabled items
    
    - passing `parentIsDisabled` as an internal prop from EuiListGroupItem and making it an array conditional solves the hover issue
    
    - the parent li is not focusable so the `:focus &` selector doesn't work either. Changing it to to the button and `+ &` solves the issue
    
    + remove unnecessary comment
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    a12e1c8 View commit details
    Browse the repository at this point in the history
  10. [EuiListGroupItemExtraAction] Add basic unit tests + clean up styles …

    …array further
    
    - the hover CSS is unnecessary if alwaysShow is true, so add a condition for it
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    49a2188 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    c2591c8 View commit details
    Browse the repository at this point in the history
  12. [EuiListGroupItemExtraAction] Fix margin-right spacing

    - currently 8px on prod which generally seems to match the button padding size better
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    4e1de76 View commit details
    Browse the repository at this point in the history
  13. [Enhancement] Improve button hitbox of tooltip wrapped items

    - this allows button content inside tooltips to grow to 100% of the EuiListGroupItem
    - this is an enhancement from current prod behavior
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    d41fa9a View commit details
    Browse the repository at this point in the history
  14. Clean up wrapText CSS

    - Remove unnecessary CSS on __inner - the width: 100% is totally unnecessary (tested with both extra action and without) and the word break can be applied to the __label CSS instead
    
    - DRY out unsetting CSS by using ternary instead of base CSS (but keep empty base for naming)
    
    - DRY out CSS by using text utils
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    19e3850 View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    425ce47 View commit details
    Browse the repository at this point in the history
  16. Fix/cleanup misc custom maxWidth behavior

    - use logical CSS property instead of max-width
    
    - do not apply maxWidthDefault emotion style if using a custom inline max-width
    
    - fix maxWidth conditional checks
    
    - remove || fallback / type def in favor of let
    
    - improve props documentation/typing
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    28aa0bd View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    ec20ddb View commit details
    Browse the repository at this point in the history
  18. misc code organization

    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    86615c1 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    aa206a5 View commit details
    Browse the repository at this point in the history
  20. [EuiListGroupItem] Add working shouldRenderCustomStyles

    + test nested `iconProps` and `extraAction` props
    
    + fix `extraAction` props not correctly passing/merging `className`
    
    + fix misc console.warn about missing EuiButtonIcon aria-label
    
    + add test for `style` prop on parent EuiListGroupItem, since it gets spread to the wrapped child and not the className wrapper
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    24fc328 View commit details
    Browse the repository at this point in the history
  21. Remove euiPinnableListGroup__itemExtraAction classes

    - they're now being correctly passed to the `EuiListGroupItemExtraAction` but they're not really doing anything / just adding a lot of noise
    
    - consumers can simply hook into `.euiListGroupItemExtraAction` instead
    
    - no Kibana references to these classes, so IMO they're safe to remove
    cee-chen committed Sep 20, 2022
    Configuration menu
    Copy the full SHA
    49fb14f View commit details
    Browse the repository at this point in the history