[EuiPageSidebar] Fix inline styles not updating if sticky is not set
#6191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
force-pushed
the
page-sidebar-fix
branch
from
030b243
to
3c4c667
Compare
- first test should fail, second test should pass
cee-chen
force-pushed
the
page-sidebar-fix
branch
from
3c4c667
to
b17f1b5
Compare
|
Built/tested locally and confirmed that this now works correctly in Kibana. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_6191/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue that Caroline was running into in her EuiPageTemplate Kibana upgrade PR (elastic/kibana#138546):
The reason why
minWidthisn't updating downstream in Kibana is becausestickyis not set in Kibana, andEuiPageSidebarhas buggy logic causing inline styles not to be correctly updated ifstickyis not set.Checklist