Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CollapsedItemActions] Account for null ref object #6145

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 17, 2022

Summary

The registerPopoverDiv callback was not accounting for null as a possible return value.
In the scenerio where popoverDiv is null and this.popoverDiv is not defined, we would attempt to add an event listener to null, which results in a type error.

Solution is to update the type and logic to account for null

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Checked Code Sandbox works for any docs examples
  • Checked for breaking changes and labeled appropriately
  • A changelog entry exists and is marked appropriately

@chandlerprall chandlerprall self-requested a review August 17, 2022 17:42
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6145/

@thompsongl thompsongl marked this pull request as ready for review August 17, 2022 18:36
Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested with the reverted docs change without error

@thompsongl thompsongl enabled auto-merge (squash) August 17, 2022 18:47
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6145/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants