Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiDescriptionList] Export subcomponent prop interfaces #6143

Merged
merged 1 commit into from
Aug 16, 2022
Merged

[EuiDescriptionList] Export subcomponent prop interfaces #6143

merged 1 commit into from
Aug 16, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Aug 16, 2022 •
edited
Loading

Summary

Required for elastic/kibana#138837

Instances of EuiDescriptionListDescription and EuiDescriptionListTitle are styled with styled-components and the prop type cannot be correctly accessed because the interface is not exported.

Exported variable 'MonListTitle' has or is using name 'EuiDescriptionListTitleProps' from external module "@elastic/eui/src/components/description_list/description_list_title" but cannot be named.

Local export resolves the problem

### Checklist

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6143/

@thompsongl thompsongl marked this pull request as ready for review August 16, 2022 15:27
@thompsongl thompsongl merged commit 4c30345 into elastic:main Aug 16, 2022
@thompsongl thompsongl mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cee-chen cee-chen cee-chen approved these changes

@chandlerprall chandlerprall Awaiting requested review from chandlerprall

Assignees
No one assigned
Labels
skip-changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thompsongl @kibanamachine @cee-chen