Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Emotion] Convert global className utilities #6124

Merged
merged 10 commits into from
Aug 16, 2022
Merged

[Emotion] Convert global className utilities #6124

merged 10 commits into from
Aug 16, 2022

Commits on Aug 11, 2022

  1. Convert text globals/utilities to Emotion 

    + fix missing CSS logical property on text truncation mixin
+ convert textLeft/Right to logical CSS
- note that we can't use the logicalTextAlign util for this as !important can't be passed to that util
    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    c88f1ea View commit details
    Browse the repository at this point in the history

  2. Pass euiTheme to globalStyles and convert euiNumberFormat

    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    28d626b View commit details
    Browse the repository at this point in the history

  3. Convert display utils to Emotion 

    + convert euiFullHeight Sass mixin to Emotion

+ move @mixin euiFullHeight to `mixins/_helpers` instead of living in `_utility`
    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    b1d25fa View commit details
    Browse the repository at this point in the history

  4. Document euiFullHeight under scroll utils 

    - since that's where the className was documented
    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    5c2d5ef View commit details
    Browse the repository at this point in the history

  5. Convert scroll globals to Emotion (+ add logical CSS properties) 

    - this requires adding a new `logicalCSSWithFallback` util, since overflow-inline/block is not yet supported on non-FF browsers

+ fix incorrect overflow mapping - inline should be x and block should be y
    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    48fe87f View commit details
    Browse the repository at this point in the history

  6. Convert .eui-isFocusable global to Emotion 

    + convert mixin to accept the entire euiThemeContext instead of just the euiTheme to match all other mixins
    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    a557e69 View commit details
    Browse the repository at this point in the history

  7. Convert responsive globals to Emotion

    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3f4187e View commit details
    Browse the repository at this point in the history

  8. Add snapshot test for quick checking of global styles output

    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    ab32f6f View commit details
    Browse the repository at this point in the history

  9. Changelog

    @cee-chen
    cee-chen committed Aug 11, 2022
    Configuration menu
    Copy the full SHA
    3e288c0 View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2022

  1. Remove .eui-isFocusable - not being used anywhere 

    + already being handled by global reset
    @cee-chen
    cee-chen committed Aug 16, 2022
    Configuration menu
    Copy the full SHA
    626c66f View commit details
    Browse the repository at this point in the history