Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiOverlayMask] Convert to Emotion; remove onClick prop #6090

Merged
merged 15 commits into from
Aug 31, 2022

Conversation

thompsongl
Copy link
Contributor

@thompsongl thompsongl commented Jul 28, 2022

Summary

Like it says on the tin.

Also,

Checklist

  • Checked in both light and dark modes
  • Checked in mobile
  • Checked in Chrome, Safari, Edge, and Firefox
  • Props have proper autodocs and playground toggles
  • Checked Code Sandbox works for any docs examples
  • Added or updated jest and cypress tests
  • Checked for breaking changes and labeled appropriately
  • Checked for accessibility including keyboard-only and screenreader modes
  • A changelog entry exists and is marked appropriately

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl thompsongl marked this pull request as ready for review August 1, 2022 17:49
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl
Copy link
Contributor Author

Setting back to draft until EuiPortal changes are settled

@thompsongl thompsongl marked this pull request as draft August 4, 2022 14:23
@thompsongl thompsongl marked this pull request as ready for review August 22, 2022 20:20
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl
Copy link
Contributor Author

Hmm now belowHeader isn't working

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@thompsongl
Copy link
Contributor Author

Ready again, @chandlerprall

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

Copy link
Contributor

@chandlerprall chandlerprall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM! Tested in the preview docs

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_6090/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[EuiOverlayMask] Remove onClick in favor of EuiFocusTrap combo
3 participants