Emotion/eui text 2 #5931
Closed
Emotion/eui text 2 #5931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5931/ |
cee-chen
force-pushed
the
emotion/eui-text-2
branch
from
354566d
to
84fcc66
Compare
TODO: EuiCode variables were not converted, per direction from Caroline
- simplifies usage
+ convert optional params to an options object + clean up euiFontSize and euiTitle fns - remove `scale` fallback since the utils don't really make sense without that param, and remove rem fallbacks in place of just single options fallback
- since there isn't a .9 scale size, we should just use `em` to make it relative - since `.euiCode` also uses `.9em`, we can now remove the `:not()` selector
- attempting to account for `em` margins + add :not(:last-child) selector per Caroline's request
…file - might as well do it while I'm here and thinking about it + expanded our logicals helper to include all logical `border` properties, since the converted CSS uses this
+ switch to logical properties
- text alignment already has its own CSS utils that users can call directly (that we can also convert any Kibanau sage into), so I feel very safe making this change, and I'd rather people not continue to hook into these classNames
- since they're no longer setting CSS - we should convert Kibana usages to the component
+ fix syntax highlighting
- which allows us to skip nesting multiple div wrappers when using `textAlign` and `color` props, and also will allow for more flexible EuiText usage when deprecating CSS classes
- until it's converted to CSS-in-JS
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
- turn off whitespace diffs for this change
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
This reverts commit bdbcc81.
+ tweak EuiTextColor playground to allow passing custom colors
Co-authored-by: Caroline Horn <549577+cchaos@users.noreply.github.com>
cee-chen
force-pushed
the
emotion/eui-text-2
branch
from
84fcc66
to
36f73d1
Compare
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5931/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5931/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5931/ |
|
Closing this test PR, Greg turned off emotion source maps in main and the original PR (#5895) has been updated accordingly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing