May 2022 deprecations #5868

cee-chen · 2022-05-04T16:49:29Z

Summary

Per #1469:

Remove Popper popoverPosition options from EuiDatePicker ([EuiDatePicker] react-datepicker to src/; use EUI services #5339 (review))
Remove PartitionConfig from Charts theme Update elastic-charts to v41.0.1 #5492
Remove data-gridcell-id attribute from EuiDataGridCell #5515

Extra deprecations found throughout the repo:

Removed noDivider prop from EuiFilterButton - use withNext prop instead
Removed isSelected and isComplete props from EuiHorizontalStep - use status prop instead
Removed isHollow prop from EuiStep - this visual appearance is no longer used in Amsterdam
Removed condensed display prop from EuiTabs & EuiTabbedContent - this visual appearance is no longer used in Amsterdam
Removed descriptionDisplay and labelDisplay props from EuiSuggestItem - use truncate and labelWidth instead, respectively
Removed .euiButton---subdued className and $euiButtonTypes.subdued Sass variable - use text color instead
Removed .eui-textOverflowWrap - use .eui-textBreakWord instead
Removed .euiYScrollWithShadows - use .eui-yScrollWithShadows instead
EuiMarkdownEditor no longer automatically includes the tooltip plugin in custom plugin arrays passed to uiPlugins. To use EUI's tooltip plugin, use getDefaultEuiMarkdownPlugins()

Checklist

Checked for breaking changes and labeled appropriately
A changelog entry exists and is marked appropriately

cchaos · 2022-05-04T16:57:38Z

Hey @constancecchen Can we also remove the following deprecations (we never added to the issue but are sooo old now)? Just the ones I have expanded in this screenshot:

cee-chen · 2022-05-04T17:05:47Z

Ah I totally forgot to search for that, thanks Caroline! Yes, I'll make that part of this PR

kibanamachine · 2022-05-04T17:22:45Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/

…ion`

- use `theme.partition` instead

- use separate `data-gridcell-column-id` & `data-gridcell-row-index` attributes instead

…tItem`

…assed to `EuiMarkdownEditor`

cee-chen · 2022-05-04T19:23:15Z

A few quick requests from respective codeowners for a few reviews/QA, and some notes of Kibana conversions that will need to be made:

EuiDatePicker - 8a7babb - @thompsongl
- There are no current usages of popoverPosition in Kibana main
EuiCharts - 0b09e59 - @thompsongl
- Not really sure how to evaluate this one in Kibana, I assume no changes needed
EuiDataGrid - 42434ca - this is me, looks good
- There are no current usages in Kibana main
EuiFilterButton - 07f0348 - @cchaos?
- No current usages in Kibana main, only EUI
EuiHorizontalStep - 90bc8c1 - @cchaos
- There are 7 current usages in Kibana main of EuiStepsHorizontal where the removed isComplete and
  isSelected props will need to be converted to the correct status prop
EuiStep - e070e27 - @cchaos
- There are no current usages of isHollow in Kibana main
EuiTabs - f36693b
- @cchaos can you review this, particularly confirming that the changes to our own internal usages of EuiTabs were done correctly?
- There are 3 current usages in Kibana main of <EuiTabs display= that will need to be removed
EuiSuggestItem - b6c7e2a
- @thompsongl can you confirm that lines 137-139 were handled correctly? I was unsure whether or not to remove line 138 entirely
- Bizarrely enough there is 1 current usage in Kibana main of someone directly calling .euiSuggestItem__labelDisplay--expand on an item
.euiButton--subdued - 793b2a8 - @cchaos
- There are no current usages of either the className or Sass variable in Kibana main
.eui-textOverflowWrap - 5763463
- There are 4+ current usages in Kibana main that will need to be changed to .eui-textBreakWord
.euiYScrollWithShadows - c2c3be4
- There are no current usages of this className in Kibana main (just the Sass mixin).
EuiMarkdownEditor - d61acf4 - @chandlerprall
- There is 1 current usage of the editor in Kibana, but it is already using EUI's default markdown plugins and will get the tooltip, and is not affected by this deprecation

kibanamachine · 2022-05-04T19:24:47Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/

cchaos

I looked over items 4-11. LGTM!

thompsongl

There are no current usages of popoverPosition in Kibana main

🎉

EuiCharts - 0b09e59 - @thompsongl
Not really sure how to evaluate this one in Kibana, I assume no changes needed

Correct

EuiSuggestItem - b6c7e2a
@thompsongl can you confirm that lines 137-139 were handled correctly? I was unsure whether or not to remove line 138 entirely

Looks right to me!

kibanamachine · 2022-05-04T20:00:32Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/

cee-chen · 2022-05-04T20:11:38Z

Hmmm, looks like a flaky EuiDataGrid spec. linking for future reference/flake tracking: https://kibana-ci.elastic.co/job/elastic+eui+pull-request-test/7021/console

jenkins test this

kibanamachine · 2022-05-04T20:40:14Z

Preview documentation changes for this PR: https://eui.elastic.co/pr_5868/

cee-chen · 2022-05-04T22:44:31Z

Going to go ahead and merge since the remaining EuiMarkdownEditor deprecation doesn't affect Kibana. @chandlerprall if you see any issues with d61acf4 let me know and I can open up a follow-up PR.

…iDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868)

…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)

* Initial commit for EUI 57.0.0 upgrade * Handle i18n changes * Resolved type errors in DatePicker and Markdown Editor * Resolve test failures in Jest Test Suite #1. Updated multiple snapshots for euiLink and euiTitle as they have been converted to Emotion * Resolved failing tests for Jest Suite #2. Updated snapshots for euiHealth, euiAvatar, euiSpacer, euiTitle, and euiLink as they have recently been converted to Emotion * Resolved failing tests for Jest Suite 3. Updated failing snapshots as EuiSpacer, EuiText, EuiCallout, EuiHorizontalRule, EuiTitle, and EuiLink have been converted to Emotion. Updated the i18n translation snapshots * Upgrade EUI verion to 58.0.0 * Resolved tests failures from Jest Test Suite 4. Updated snapshots as EuiLink, EuiTitle, EuiHorizontalRule, EuiSpace, and EuiCallout have been converted to Emotion * Resolved failing test cases for Jest Test Suite 5. Updated snapshots as EuiLoader has been converted to Emotion * Resolved failing tests in Jest Test Suite 6. Updated snapshots as EuiSpacer, EuiHorizontalRule, Eui Callout, and EuiLink have been converted to Emotion * Resolved type errors for EuiDatePicker component * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type error within EuiContextMenu by removing the watchedItemProps prop. It was recently deprecated in EUI PR# 5880 (elastic/eui#5880) as is no longer needed * Resolved type errors by updating the popoverPlacement prop for the EuiDatePicket component with new / valid values. A list of values were deprecated and new values were added in EUI PR #5868 (elastic/eui#5868) * Resolved type error within EuiTabs by removing instances of display: condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868) * Remove deprecated `display` prop from EuiTabs * Deprecate `.eui-textOverflowWrap` * Deprecate EuiSuggestItem `labelDisplay` prop * [EuiStepsHorizontal] Replace deprecated `isComplete`/`isSelected` with `status` * Update last EuiStepsHorizontal `status` migration - this one was more complex than the previous commit due to existing `status` usage and conditional steps. Some amount of logic was simplified via `completedStep` * Resolved type error within EuiTabs by removing instances of display: condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868) * Resolved failing test cases in Jest Test Suite 5. Updated snapshots as EuiTitle has been converted to Emotion * Resovlved failing test cases in Jest Test Suite 4. Updated snapshots as EuiTitle and EuiSpacer have been converted to Emotion. Resolved failing tests for EuiLink click simlulations by esuring the test is referencing the correct element. * Resolved failing test cases in Jest Test Suite 3. Updated snapshots as EuiLink, EuiSpacr, and EuiTItle have been converted to Emotion. Updated various test cases to ensure that the references to EuiLink are correct * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases in Jest Test Suite 1. Updated snapshots as EUI text utilities have been converted to Emotion. Updated referenes to EuiLink to ensure test are simulating clicks on the correct elements * Resolved failing test for Jet Test Suite 2. Updated required snapshots. Updated references to EuiLink to ensure that tests are simulating clicks on the correct elements * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases for Jest Test Suite 5. Updated references to EuiLink to ensure tests are targeting the correct element * [CI] Auto-commit changed files from 'node scripts/eslint --no-cache --fix' * Resolved failing test cases across the Jest Test Suites. Updated required snaphots for components recently converted to Emotion. Updated test cases to ensure that tests targeting EuiLink are using the correct element. * Resolved failing tests from multiple Jest test suites. Updated snapshots for components that have recently been converted to Emotion. Updated tests that reference the EuiLink component to ensure the correct element is being targeted * Updated the getEuiStepsHorizontal function. Previously, this function used the .euiStepHorizontal-isSelected class (now deprecated) to determine which step was current. The function has been updated to use the status prop. * Updated Jest integration test snapshots to account for the recent conversion of EuiLoader to Emotion * Resolved failing tests in Jest suites 2 and 4. Updated required snapshots and references for tests using EuiLink * Removed a console statement. Extracted a nested turnary operation into its own function. * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * Rollback new turnary function and replace it with a simple if/else * [CI] Auto-commit changed files from 'node scripts/precommit_hook.js --ref HEAD~1..HEAD --fix' * Resolved failing test cases in Jest Suites 3 and 5 by updating required snapshots * revert doc_viewer_source test and snapshot changes * Take care of merge conflict in license_checker: * Reverted .render() change for analytics_no_data_page.component.test.tsx. Restored snapshot * Reverted .render() change for analytics_no_data_page.component.test.tsx. Restored snapshot Co-authored-by: Constance Chen <constance.chen@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Greg Thompson <thompson.glowe@gmail.com>

cee-chen added the breaking change label May 4, 2022

cee-chen requested a review from thompsongl May 4, 2022 16:52

cee-chen added 13 commits May 4, 2022 11:54

Removed EuiDatePicker accepting deprecated values for `popoverPosit…

8a7babb

…ion`

Removed partition from Charts theme config

0b09e59

- use `theme.partition` instead

Removed data-gridcell-id from EuiDataGrid cells

42434ca

- use separate `data-gridcell-column-id` & `data-gridcell-row-index` attributes instead

Changelog

97d3d0a

Removed noDivider prop from EuiFilterButton

07f0348

Removed isSelected and isComplete props from EuiHorizontalStep

90bc8c1

Removed isHollow prop from EuiStep

e070e27

Removed display prop from EuiTabs/EuiTabbedContent

f36693b

Removed descriptionDisplay and labelDisplay props from `EuiSugges…

b6c7e2a

…tItem`

Removed .euiButton--subdued/$euiButtonTypes.subdued

793b2a8

Removed .eui-textOverflowWrap

5763463

Removed .euiYScrollWithShadows

c2c3be4

Removed automatic inclusion of tooltip plugin in custom uiPlugins p…

d61acf4

…assed to `EuiMarkdownEditor`

cee-chen force-pushed the may-deprecations branch from 7d176a4 to d61acf4 Compare May 4, 2022 18:54

cee-chen requested review from cchaos and chandlerprall May 4, 2022 19:24

[PR feedback] EuiStepsHorizontalProps typing

09d803b

cchaos approved these changes May 4, 2022

View reviewed changes

thompsongl approved these changes May 4, 2022

View reviewed changes

cee-chen merged commit 170a8db into elastic:main May 4, 2022

cee-chen deleted the may-deprecations branch May 4, 2022 22:44

breehall mentioned this pull request May 16, 2022

Upgrade EUI to v58.0.0 elastic/kibana#132257

Merged

breehall added a commit to elastic/kibana that referenced this pull request May 25, 2022

Resolved type error within EuiTabs by removing instances of display: …

796aeb2

…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)

breehall added a commit to elastic/kibana that referenced this pull request May 25, 2022

Resolved type error within EuiTabs by removing instances of display: …

7c51acd

…condensed as it is no longer a part of the Amsterdam theme via EUI PR #5868(elastic/eui#5868)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

May 2022 deprecations #5868

May 2022 deprecations #5868

cee-chen commented May 4, 2022 •

edited

Loading

cchaos commented May 4, 2022

cee-chen commented May 4, 2022

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022 •

edited

Loading

kibanamachine commented May 4, 2022

cchaos left a comment

thompsongl left a comment

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022

May 2022 deprecations #5868

May 2022 deprecations #5868

Conversation

cee-chen commented May 4, 2022 • edited Loading

Summary

Checklist

cchaos commented May 4, 2022

cee-chen commented May 4, 2022

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022 • edited Loading

kibanamachine commented May 4, 2022

cchaos left a comment

Choose a reason for hiding this comment

thompsongl left a comment

Choose a reason for hiding this comment

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022

kibanamachine commented May 4, 2022

cee-chen commented May 4, 2022

cee-chen commented May 4, 2022 •

edited

Loading

cee-chen commented May 4, 2022 •

edited

Loading