Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiPopover][EuiContextMenu] Attempt to manually restore focus to the toggling button on popover close if focus becomes stranded #5760

Merged
merged 10 commits into from
Apr 7, 2022
Merged

[EuiPopover][EuiContextMenu] Attempt to manually restore focus to the toggling button on popover close if focus becomes stranded #5760

merged 10 commits into from
Apr 7, 2022

Commits on Apr 5, 2022

  1. Upgrade tabbable to latest to get focusable API 

    + update import/fix types
    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    b60e810 View commit details
    Browse the repository at this point in the history

  2. Update popovers to manually attempt to always focus back onto the tog… 

    …gle button on trap deactivation
    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    8eb8105 View commit details
    Browse the repository at this point in the history

  3. Update downstream snapshots

    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ac56282 View commit details
    Browse the repository at this point in the history

  4. Add changelog entry

    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    a429a4c View commit details
    Browse the repository at this point in the history

  5. Move refocusButtonOnClose logic to only occur on escape key 

    + improve unit tests to use .invoke()
    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    ae21121 View commit details
    Browse the repository at this point in the history

  6. Narrow down scope of bugfix further 

    - Instead of always running this logic, wait the popover to finish closing and check for stranded document.activeElement first before manually restoring focus
    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    254dc79 View commit details
    Browse the repository at this point in the history

  7. hello snapshots my old friend 

    i've come to update you again
because a code change softly creeping
left its diffs while I was sleeping
    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    75342b4 View commit details
    Browse the repository at this point in the history

  8. Tweak changelog entry

    @cee-chen
    cee-chen committed Apr 5, 2022
    Configuration menu
    Copy the full SHA
    c01d2f4 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Add clearTimeout for unmount/open of stranded focus logic 

    + improve listener cleanup unit tests
    @cee-chen
    cee-chen committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    39e49e4 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] fix accidental deletion

    @cee-chen
    cee-chen committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    148ddb2 View commit details
    Browse the repository at this point in the history