Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiPageTemplate Feature] [Docs] Create new section for “Templates” #5625

Conversation

cchaos
Copy link
Contributor

@cchaos cchaos commented Feb 10, 2022

This is the first of many PR's to breakdown the work being done for EuiPageTemplate in #5454

Moves Page Template, SuperDatePicker, and Searchable Sitewide Template into a new section

Screen Shot 2022-02-10 at 14 30 05 PM

Stubs in placeholder page for in lower level page components

Screen Shot 2022-02-10 at 14 30 13 PM

And fixes routes associated with these new/old pages.

Checklist

Nothing new was added, just shifting some docs pages and routes

- Moves Page Template, SuperDatePicker, and Searchable Sitewide Template
- Stubs in placeholder page for in lower level page components
- Fixes routes
@cchaos cchaos changed the title [Feature] [Docs] Create new section for “Templates” [EuiPageTemplate Feature] [Docs] Create new section for “Templates” Feb 10, 2022
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/

@miukimiu miukimiu self-requested a review February 11, 2022 12:44
Copy link
Contributor

@miukimiu miukimiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🎉

This new section makes total sense.

Tested in Firefox, Safari, and Chrome. Tested the links and (re)read the texts.

Just have a few suggestions.

src-docs/src/views/page/page_template_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_template_example.js Outdated Show resolved Hide resolved
src-docs/src/views/page/page_template_example.js Outdated Show resolved Hide resolved
Copy link
Contributor

@thompsongl thompsongl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Elizabet's edits

cchaos and others added 2 commits February 11, 2022 10:17
Co-authored-by: Elizabet Oliveira <elizabet.oliveira@elastic.co>
@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/

@kibanamachine
Copy link

Preview documentation changes for this PR: https://eui.elastic.co/pr_5625/

@cchaos cchaos merged commit a74ce1c into elastic:feature/page_templates Feb 11, 2022
@cchaos cchaos deleted the feature_page_templates/new_sidenav branch February 11, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants