Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EuiSuperSelect] Fix regenerating and missing IDs #5197

Merged
merged 6 commits into from
Sep 20, 2021
Merged

[EuiSuperSelect] Fix regenerating and missing IDs #5197

merged 6 commits into from
Sep 20, 2021

Commits on Sep 16, 2021

  1. Fix regenerating screen reader ID

    @cee-chen
    cee-chen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    eefcefd View commit details
    Browse the repository at this point in the history

  2. Fix undefined input ID 

    - falls back to a generated ID if passed ID is undefined
    @cee-chen
    cee-chen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    d014de5 View commit details
    Browse the repository at this point in the history

  3. Update snapshots to w/ new superselect ID

    @cee-chen
    cee-chen committed Sep 16, 2021
    Configuration menu
    Copy the full SHA
    b3fcf69 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Merge branch 'master' into use-generated-html-id-super-select

    @cee-chen
    cee-chen committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    1afe332 View commit details
    Browse the repository at this point in the history

  2. [PR feedback] Remove unnecessary input ID/aria-labelledby association

    @cee-chen
    cee-chen committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    bc39625 View commit details
    Browse the repository at this point in the history

  3. Update snapshots

    @cee-chen
    cee-chen committed Sep 20, 2021
    Configuration menu
    Copy the full SHA
    96e079b View commit details
    Browse the repository at this point in the history