[EuiSuperSelect] Fix regenerating and missing IDs #5197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- falls back to a generated ID if passed ID is undefined
cee-chen
commented
Sep 16, 2021
| @@ -108,7 +108,7 @@ export const EuiSuperSelectControl: <T extends string>( | |||
| side: 'right', | |||
| }; | |||
|
|
|||
| const screenReaderId = htmlIdGenerator()(); | |||
| const screenReaderId = useGeneratedHtmlId(); | |||
|
Hahaha sorry, you're too fast! I was still slowly writing up my comments 😂 🐢 |
1 task
My apologies, I should have taken a pause before approving. I took a second look after I saw your comment and responded in kind. |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5197/ |
|
Preview documentation changes for this PR: https://eui.elastic.co/pr_5197/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
undefinedRelated parent PR:
Checklist
N/A, internal/tech debt only - changelog will be in parent #5195 PR