Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add K6 overrides and more advanced theming system #191

Merged
merged 12 commits into from
Dec 12, 2017
Merged

Conversation

snide
Copy link
Contributor

@snide snide commented Dec 6, 2017

By providing a K6 theme over the K7 components, we're hoping to enable Kibana engineers to consume this framework today, while retaining a consistent look-and-feel in the Kibana UI.

Guidelines

  1. Only override SCSS variables.
  2. If necessary, abstract parts of KUI behind variables and mixins to enable No Elasticsearch assets SVG #1.
  3. Avoid overriding selectors and styles directly as much as possible. Only do this as a last resort.

K6 theme

The K6 theme consists of:

  1. Changing colors to match the palette.
  2. Changing font-size to match.
  3. Changing some spacing to match, which generally just means making spacing tighter.

@snide snide changed the title DO NOT MERGE: Add K6 overrides to light theme. DO NOT MERGE: Add K6 overrides and more advanced theming ystem Dec 6, 2017
@cjcenizal cjcenizal mentioned this pull request Dec 8, 2017
5 tasks
Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment. This PR needs a rebase and a note in the CHANGELOG that we've adding two new themes, and then I think we're good to merge!

@@ -0,0 +1,2 @@
// @import 'size';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we delete this line?

@cjcenizal cjcenizal changed the title DO NOT MERGE: Add K6 overrides and more advanced theming ystem Add K6 overrides and more advanced theming system Dec 11, 2017
@snide
Copy link
Contributor Author

snide commented Dec 12, 2017

@cjcenizal I rearranged how we import sass in regards to themes. Wanted to contain themes to their own directory vs having the files spread out in each folder that needed it. Also went ahead and wrote up docs for how to make themes. Give it another look, then we should be OK to merge.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Let's merge this and cut a new release!

@snide snide merged commit 941f5d8 into elastic:master Dec 12, 2017
@snide snide deleted the eui/k6 branch December 12, 2017 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants