Run Cypress tests in release scripts

- not sure how we missed this oversight - it's very possible for individual PRs to have failing E2E/Cypress tests but for combined PRs to fail in main

scripts/release.js

@@ -44,9 +44,9 @@ if (args.dry_run) {
   // ensure git and local setup is at latest
   await ensureCorrectSetup();
 
-  // run linting and unit tests
+  // run lint, unit, and e2e tests
   if (args.steps.indexOf('test') > -1) {
-    execSync('npm test', execOptions);
+    execSync('npm test-ci', execOptions);
   }
 
   // (trans|com)pile `src` into `lib` and `dist`
@@ -115,8 +115,7 @@ function parseArguments() {
 
   const allSteps = ['test', 'build', 'version', 'tag', 'publish', 'docs'];
   parser.add_argument('--steps', {
-    help:
-      'Which release steps to run; a comma-separated list of values that can include "test", "build", "version", "tag", "publish" and "docs". If no value is given, all steps are run. Example: --steps=test,build,version,tag',
+    help: 'Which release steps to run; a comma-separated list of values that can include "test", "build", "version", "tag", "publish" and "docs". If no value is given, all steps are run. Example: --steps=test,build,version,tag',
     default: allSteps.join(','),
   });
 

wiki/eui-team-processes/releasing-versions.md

@@ -94,7 +94,7 @@ This provides a walkthrough of the patching & backport release process; examples
       * Remember to continue cherry picking with `git cherry-pick --continue` until all commits have been applied
 * Start the dev server and check that the intended changes have been properly applied, you don't want to repeat this process to patch the patch - `yarn start`
 * Once everything looks correct, it's time to release; the `yarn release` script only works when releasing from `main`, so we'll run [a subset of those steps](https://github.com/elastic/eui/blob/06fc9a6880766168aec1a622873e7f6fe1b3d42b/scripts/release.js#L34-L57) manually
-  * Run the unit tests again - `npm test`
+  * Run the unit tests again - `npm test-ci`
   * Create the release builds - `npm run build`
   * Update the I18n tokens - `npm run update-token-changelog -- patch`
   * Update the changelog - `npm run update-changelog-manual --release=patch`