[DOCS] Update URLs in plugin document #89221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
v8.5.0
needs:triage
abdonpijpelink
added
>docs
|
Pinging @elastic/es-docs (Team:Docs) |
abdonpijpelink
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Thanks @GabyCT ! I've left a couple of minor suggestions to also use the {es-repo} variable.
docs/plugins/authors.asciidoc
Outdated
| @@ -3,12 +3,12 @@ | |||
|
|
|||
| :plugin-properties-files: {elasticsearch-root}/build-tools/src/main/resources | |||
|
|
|||
| The Elasticsearch repository contains https://github.com/elastic/elasticsearch/tree/master/plugins/examples[examples of plugins]. Some of these include: | |||
| The Elasticsearch repository contains https://github.com/elastic/elasticsearch/tree/main/plugins/examples[examples of plugins]. Some of these include: | |||
There was a problem hiding this comment.
Suggested change
| The Elasticsearch repository contains https://github.com/elastic/elasticsearch/tree/main/plugins/examples[examples of plugins]. Some of these include: | |
| The Elasticsearch repository contains {es-repo}tree/main/plugins/examples[examples of plugins]. Some of these include: |
There was a problem hiding this comment.
@abdonpijpelink thanks for the feedback changes applied
docs/plugins/authors.asciidoc
Outdated
Comment on lines
8
to
11
| * a plugin with https://github.com/elastic/elasticsearch/tree/main/plugins/examples/custom-settings[custom settings] | ||
| * adding https://github.com/elastic/elasticsearch/tree/main/plugins/examples/rest-handler[custom rest endpoints] | ||
| * adding a https://github.com/elastic/elasticsearch/tree/main/plugins/examples/rescore[custom rescorer] | ||
| * a script https://github.com/elastic/elasticsearch/tree/main/plugins/examples/script-expert-scoring[implemented in Java] |
There was a problem hiding this comment.
Suggested change
| * a plugin with https://github.com/elastic/elasticsearch/tree/main/plugins/examples/custom-settings[custom settings] | |
| * adding https://github.com/elastic/elasticsearch/tree/main/plugins/examples/rest-handler[custom rest endpoints] | |
| * adding a https://github.com/elastic/elasticsearch/tree/main/plugins/examples/rescore[custom rescorer] | |
| * a script https://github.com/elastic/elasticsearch/tree/main/plugins/examples/script-expert-scoring[implemented in Java] | |
| * a plugin with {es-repo}tree/main/plugins/examples/custom-settings[custom settings] | |
| * adding {es-repo}tree/main/plugins/examples/rest-handler[custom rest endpoints] | |
| * adding a {es-repo}tree/main/plugins/examples/rescore[custom rescorer] | |
| * a script {es-repo}tree/main/plugins/examples/script-expert-scoring[implemented in Java] |
There was a problem hiding this comment.
@abdonpijpelink thanks for the feedback changes applied
This PR updates the URLs for several references that are being used in the plugin document. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
GabyCT
force-pushed
the
topic/updateauthorasciidoc
branch
from
d2fd1ed
to
063fed2
Compare
abdonpijpelink
pushed a commit
to abdonpijpelink/elasticsearch
that referenced
this pull request
Aug 10, 2022
This PR updates the URLs for several references that are being used in the plugin document. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
abdonpijpelink
pushed a commit
to abdonpijpelink/elasticsearch
that referenced
this pull request
Aug 10, 2022
This PR updates the URLs for several references that are being used in the plugin document. Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 10, 2022
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the URLs for several references that are being
used in the plugin document.
Signed-off-by: Gabriela Cervantes gabriela.cervantes.tellez@intel.com