-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: refresh the rollup index as part of the rollup indexer actions #86992
Merged
salvatore-campagna
merged 17 commits into
elastic:master
from
salvatore-campagna:fix/81983-security-tests-rollup
Jul 6, 2022
Merged
fix: refresh the rollup index as part of the rollup indexer actions #86992
salvatore-campagna
merged 17 commits into
elastic:master
from
salvatore-campagna:fix/81983-security-tests-rollup
Jul 6, 2022
Commits on May 20, 2022
-
fix: move refresh just before the match_all query
Using the command line provided in elastic#81983 I could not reproduce the issue. Anyway, changing the timeout from 5 seconds to just 1 second I could reproduce the issue. At the end, keeping a timeout of 1 second I could fix the issue moving the refresh operation just before running the match_all query. My understanding is that the timeout is used to give the rollup job enough time to complete the rollup operation. Anyway, other than that, after the rollup job has written data into the rollup index we need to refresh it in order for the subsequent search operation to hit the expected rolledup document.
Configuration menu - View commit details
-
Copy full SHA for 7968c70 - Browse repository at this point
Copy the full SHA 7968c70View commit details
Commits on May 31, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 665647d - Browse repository at this point
Copy the full SHA 665647dView commit details
Commits on Jun 1, 2022
-
Revert "fix: move refresh just before the match_all query"
Instead of refreshing from the yaml test we refresh once the indexing operation is complete in the callback. This reverts commit 7968c70.
Configuration menu - View commit details
-
Copy full SHA for d3e9dd1 - Browse repository at this point
Copy the full SHA d3e9dd1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6385514 - Browse repository at this point
Copy the full SHA 6385514View commit details
Commits on Jun 8, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f48593c - Browse repository at this point
Copy the full SHA f48593cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea442d5 - Browse repository at this point
Copy the full SHA ea442d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2688bb1 - Browse repository at this point
Copy the full SHA 2688bb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8e11d8c - Browse repository at this point
Copy the full SHA 8e11d8cView commit details
Commits on Jun 9, 2022
-
Configuration menu - View commit details
-
Copy full SHA for a46af31 - Browse repository at this point
Copy the full SHA a46af31View commit details -
Configuration menu - View commit details
-
Copy full SHA for f9bbc68 - Browse repository at this point
Copy the full SHA f9bbc68View commit details -
fix: just mock the search action call
The client is used to call the refresh action too. As a result, using 'any()' as the action would match both the search and refresh actions while we just need to handle the search action.
Configuration menu - View commit details
-
Copy full SHA for 691c54a - Browse repository at this point
Copy the full SHA 691c54aView commit details
Commits on Jul 5, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 3bd3a94 - Browse repository at this point
Copy the full SHA 3bd3a94View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1f70f3 - Browse repository at this point
Copy the full SHA c1f70f3View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4e5fc42 - Browse repository at this point
Copy the full SHA 4e5fc42View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16bd5b0 - Browse repository at this point
Copy the full SHA 16bd5b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 24ee30a - Browse repository at this point
Copy the full SHA 24ee30aView commit details -
fix: move listener callback into the refresh listener
We also need to mock the refresh response for the client to actually propagate the result of the refresh call.
Configuration menu - View commit details
-
Copy full SHA for ceb5c6b - Browse repository at this point
Copy the full SHA ceb5c6bView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.