Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Script: fields API for byte, double, float, integer, long, short #81126

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Script: fields API for byte, double, float, integer, long, short #81126

merged 4 commits into from
Nov 30, 2021

Conversation

stu-elastic
Copy link
Contributor

@stu-elastic stu-elastic commented Nov 29, 2021 •
edited
Loading

  • Adds DocValuesField for byte, double, float, integer, long and short

The integral types implement ScriptDocValues.Supplier<Long> while the
floating point types implement ScriptDocValues.Supplier<Double>.

Refs: #79105

@stu-elastic
Script: fields API for byte, double, float, integer, long, short
e115bb7 
* Adds DocValuesField for byte, double, float, integer, long and short

The integral types implement ScriptDocValues.Supplier<Long> while the
floating point types implement ScriptDocValues.Supplier<Double>.

Refs: elastic#79105
@stu-elastic stu-elastic marked this pull request as ready for review November 29, 2021 22:13
@stu-elastic stu-elastic added :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement labels Nov 29, 2021
@elasticmachine elasticmachine added the Team:Core/Infra Meta label for core/infra team label Nov 29, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (Team:Core/Infra)

This was referenced Nov 29, 2021
Open
Closed
jdconrad
jdconrad approved these changes Nov 30, 2021
View reviewed changes
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Big step forward :) for the scripting fields API. I left a few minor requests for some comment/JavaDoc clean up.

...ang-painless/src/yamlRestTest/resources/rest-api-spec/test/painless/50_script_doc_values.yml Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/DoubleDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ByteDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/LongDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/LongDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java Outdated Show resolved Hide resolved
server/src/main/java/org/elasticsearch/script/field/ShortDocValuesField.java Outdated Show resolved Hide resolved
@stu-elastic stu-elastic merged commit fe74f97 into elastic:master Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jdconrad jdconrad jdconrad approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >enhancement Team:Core/Infra Meta label for core/infra team v8.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@stu-elastic @elasticmachine @jdconrad @elasticsearchmachine