Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use epoch_millis in can_match date range tests #77464

Merged
merged 1 commit into from
Sep 10, 2021

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Sep 8, 2021

There is a known issue in 7.x where a date parameter of a range query can be interpreted as the number of years if no format is provided. This commit always uses epoch_millis format to avoid this issue in CanMatchPreFilterSearchPhaseTests.

Relates #63692
Closes #77122

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Search/Search Search-related issues that do not fall into other categories v7.16.0 v7.15.1 v7.14.2 labels Sep 8, 2021
@elasticmachine elasticmachine added the Team:Search Meta label for search team label Sep 8, 2021
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (Team:Search)

@dnhatn dnhatn added the auto-backport Automatically create backport pull requests when merged label Sep 8, 2021
Copy link
Member

@cbuescher cbuescher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Sep 10, 2021

Thanks @cbuescher.

@dnhatn dnhatn merged commit c6700d7 into elastic:7.x Sep 10, 2021
@dnhatn dnhatn deleted the 7x-fix-can-match-date-range branch September 10, 2021 14:07
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Sep 13, 2021
There is a known issue in 7.x where a date parameter of a range query 
can be interpreted as the number of years if no format is provided.
This commit always uses epoch_millis format to avoid this issue in
CanMatchPreFilterSearchPhaseTests.

Relates elastic#63692
Closes elastic#77122
elasticsearchmachine pushed a commit that referenced this pull request Sep 13, 2021
There is a known issue in 7.x where a date parameter of a range query 
can be interpreted as the number of years if no format is provided.
This commit always uses epoch_millis format to avoid this issue in
CanMatchPreFilterSearchPhaseTests.

Relates #63692
Closes #77122
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :Search/Search Search-related issues that do not fall into other categories Team:Search Meta label for search team >test Issues or PRs that are addressing/adding tests v7.14.2 v7.15.1 v7.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants