-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Json processor: allow duplicate keys #74956
Merged
felixbarny
merged 11 commits into
elastic:master
from
felixbarny:json-allow_duplicate_keys
Jul 6, 2021
Merged
Json processor: allow duplicate keys #74956
felixbarny
merged 11 commits into
elastic:master
from
felixbarny:json-allow_duplicate_keys
Jul 6, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixbarny
added
>enhancement
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
v8.0.0
Team:Data Management
Meta label for data/management team
v7.15.0
labels
Jul 6, 2021
Pinging @elastic/es-core-features (Team:Core/Features) |
elasticsearchmachine
added
the
external-contributor
Pull request authored by a developer outside the Elasticsearch team
label
Jul 6, 2021
felixbarny
changed the title
Json allow duplicate keys
Json processor: allow duplicate keys
Jul 6, 2021
martijnvg
reviewed
Jul 6, 2021
modules/ingest-common/src/yamlRestTest/resources/rest-api-spec/test/ingest/140_json.yml
Show resolved
Hide resolved
martijnvg
approved these changes
Jul 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (assuming build will succeed)
felixbarny
added
the
auto-backport
Automatically create backport pull requests when merged
label
Jul 6, 2021
elasticsearchmachine
pushed a commit
to elasticsearchmachine/elasticsearch
that referenced
this pull request
Jul 6, 2021
💚 Backport successful
|
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Data Management/Ingest Node
Execution or management of Ingest Pipelines including GeoIP
>enhancement
external-contributor
Pull request authored by a developer outside the Elasticsearch team
Team:Data Management
Meta label for data/management team
v7.15.0
v8.0.0-alpha1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to support creating an ingest pipeline for ECS JSON logs.
Due to how some logging frameworks work, ECS JSON logs may contain duplicate keys. Instead of failing, the JSON parser should be more lenient and prefer the last value.