Ensure notify when proxy connections disconnect #65697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnhatn
added
>bug
:Distributed/Network
|
Pinging @elastic/es-distributed (Team:Distributed) |
dnhatn
requested review from
original-brownbear
and removed request for
henningandersen
original-brownbear
approved these changes
Dec 2, 2020
server/src/internalClusterTest/java/org/elasticsearch/search/ccs/CrossClusterSearchIT.java
Outdated
Show resolved
Hide resolved
server/src/internalClusterTest/java/org/elasticsearch/search/ccs/CrossClusterSearchIT.java
Outdated
Show resolved
Hide resolved
|
Thanks Armin! |
dnhatn
added a commit
that referenced
this pull request
Dec 3, 2020
TransportService doesn't respond to the pending requests of proxy connections when the underlying connections get disconnected because proxy connections do not override the getCacheKey method. Some CCS requests would never be completed because of this bug.
dnhatn
added a commit
that referenced
this pull request
Dec 3, 2020
TransportService doesn't respond to the pending requests of proxy connections when the underlying connections get disconnected because proxy connections do not override the getCacheKey method. Some CCS requests would never be completed because of this bug.
dnhatn
added a commit
that referenced
this pull request
Dec 3, 2020
TransportService doesn't respond to the pending requests of proxy connections when the underlying connections get disconnected because proxy connections do not override the getCacheKey method. Some CCS requests would never be completed because of this bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportService doesn't respond to the pending requests of proxy connections when the underlying connections get disconnected because proxy connections do not override the getCacheKey method. Some CCS requests would never be completed because of this bug.
I found this while working on the cross-clusters task cancellation in #65443.