Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up interval rounding (backport of #63245) #63364

Merged
merged 1 commit into from
Oct 7, 2020

Commits on Oct 6, 2020

  1. Speed up interval rounding (elastic#63245)

    This speeds up date_histogram by precomputing the rounding points for
    date intervals like `10d`. The speedup for the rounding itself is
    between 18% (UTC many buckets) and 65% (US Eastern Time few buckets).
    43% seems like it'd be pretty common:
    
    ```
    Benchmark   (count)  (interval)                   (range)           (zone)  Mode  Cnt          Score         Error  Units
    before     10000000         10d  2000-10-28 to 2000-10-31              UTC  avgt   10  130822390.700 ±  177466.657  ns/op
    before     10000000         10d  2000-10-28 to 2000-10-31 America/New_York  avgt   10  189236837.930 ± 7958933.566  ns/op
    after      10000000         10d  2000-10-28 to 2000-10-31              UTC  avgt   10   66413746.325 ± 1578834.032  ns/op
    after      10000000         10d  2000-10-28 to 2000-10-31 America/New_York  avgt   10   65656941.375 ±  291608.870  ns/op
    
    before     10000000          2h  2000-10-28 to 2000-10-31              UTC  avgt   10  130854975.013 ±  369133.702  ns/op
    before     10000000          2h  2000-10-28 to 2000-10-31 America/New_York  avgt   10  165831615.257 ±  139074.982  ns/op
    after      10000000          2h  2000-10-28 to 2000-10-31              UTC  avgt   10  107832636.671 ± 3502704.198  ns/op
    after      10000000          2h  2000-10-28 to 2000-10-31 America/New_York  avgt   10  107608802.940 ±  979286.160  ns/op
    ```
    
    Speedup for the date_histogram is likely to vary based on how much IO
    dominates the collection.
    nik9000 committed Oct 6, 2020
    Configuration menu
    Copy the full SHA
    9ec12fb View commit details
    Browse the repository at this point in the history