Remove Dead Code from Closed Index Snapshot Logic #56764
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code path for closed indices is dead code here ever since elastic#39644 because `shards(currentState, indexIds, ...)` does not set `MISSING` on a closed index's shard any longer. => simplified the code accordingly.
original-brownbear
added
>non-issue
:Distributed/Snapshot/Restore
|
Pinging @elastic/es-distributed (:Distributed/Snapshot/Restore) |
tlrx
approved these changes
May 14, 2020
There was a problem hiding this comment.
since #39644
becauseshards(currentState, indexIds, ...)does not set
MISSINGon a closed index's shard any longer.
Just to reword what you said: #39644 removed a specific condition on the index metadata state CLOSE that makes the shards() method to always set MISSING on a closed index's shard. So since #39644 this method sets MISSING for shards if they are unassigned or not started whatever the state OPEN/CLOSE of the index they belong to.
Your change make it clearer that we only care about missing shardsand make no distinction between missing closed and missing open shards.
LGTM
|
Thanks Tanguy! + Good point, I reworded the PR description :) |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 13, 2020
The code path for closed indices is dead code here ever since elastic#39644 because `shards(currentState, indexIds, ...)` does not set `MISSING` on a closed index's shard that is assigned any longer. Before that change it would always set `MISSING` for a closed index's shard even it was assigned. => simplified the code accordingly.
original-brownbear
added a commit
that referenced
this pull request
Jul 13, 2020
The code path for closed indices is dead code here ever since #39644 because `shards(currentState, indexIds, ...)` does not set `MISSING` on a closed index's shard that is assigned any longer. Before that change it would always set `MISSING` for a closed index's shard even it was assigned. => simplified the code accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code path for closed indices is dead code here ever since #39644
because
shards(currentState, indexIds, ...)does not setMISSINGon a closed index's shard that is assigned any longer. Before that change it would always setMISSINGfor a closed index's shard even it was assigned.=> simplified the code accordingly.