Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform] Remove node.attr.transform.remote_connect and use new remote node role #54217

Conversation

benwtrent
Copy link
Member

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute node.attr.transform.remote_connect is no longer necessary.

closes #54179

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

Copy link
Contributor

@hendrikmuhs hendrikmuhs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@benwtrent benwtrent merged commit 202b4fb into elastic:master Mar 25, 2020
@benwtrent benwtrent deleted the feature/transforms-replace-transform-remote-cluster-setting branch March 25, 2020 19:05
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 25, 2020
…ote cluster client node role (elastic#54217)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes elastic#54179
benwtrent added a commit to benwtrent/elasticsearch that referenced this pull request Mar 25, 2020
…ote cluster client node role (elastic#54217)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes elastic#54179
benwtrent added a commit that referenced this pull request Mar 25, 2020
…ote cluster client node role (#54217) (#54224)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes #54179
benwtrent added a commit that referenced this pull request Mar 25, 2020
…ote cluster client node role (#54217) (#54226)

With the addition of a formal role for nodes indicating remote cluster connection, the transform specific attribute `node.attr.transform.remote_connect` is no longer necessary.

closes #54179
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Transform] remove transform remote connect
4 participants