Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Fix incremental build support copying REST api and tests #52896

Merged
merged 1 commit into from
Feb 27, 2020

Commits on Feb 27, 2020

  1. Fix incremental build support for copying REST api and tests (elastic…

    …#52860)
    
    A recent PR elastic#52114 introduced two new tasks to copy the REST api and tests.
    A couple bugs were found in that initial PR that prevents the incremental
    build from working as expected.
    
    The pattern match of empty string is equivalent to match all and it was coded
    as match none. Fixed with explicit checks against empty patterns.
    
    The fileCollection.plus return value was ignored. Fixed by changing how the
    input's fileTree is constructed.
    
    If a project has an src/test/resources directory, and tests are being copied
    without a rest-api-spec/test directory could result no-op. Masked by the other
    bugs and fixed by minor changes to logic to determine if a project has tests.
    jakelandis committed Feb 27, 2020
    Configuration menu
    Copy the full SHA
    7c30103 View commit details
    Browse the repository at this point in the history