Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Correct multi search API docs #52523

Merged
merged 2 commits into from
Feb 24, 2020
Merged

[DOCS] Correct multi search API docs #52523

merged 2 commits into from
Feb 24, 2020

Conversation

jrodewig
Copy link
Contributor

Changes

  • Adds an example request to the top of the page.
  • Relocates several parameters erroneously listed under "Request body"
    to the appropriate "Query parameters" section.
  • Updates the "Request body" section to better document the NDJSON
    structure of msearch requests.

Closes #52477.

* Adds an example request to the top of the page.
* Relocates several parameters erroneously listed under "Request body"
to the appropriate "Query parameters" section.
* Updates the "Request body" section to better document the NDJSON
  structure of msearch requests.
@jrodewig jrodewig added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Feb 19, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Search)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

Copy link
Contributor

@romseygeek romseygeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up! A couple of nits, but otherwise LGTM - no need for another review.

This parameter also applies to <<indices-aliases,index aliases>> that point to a
missing or closed index.

`expand_wildcards`:::
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this reuse the common-parms include as done for the request parameter above?


`preference`:::
(Optional, string)
Node or shard used to perform the search.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we specify the default value here?

`request_cache`:::
(Optional, boolean)
If `true`, the request cache can be used for this search.
See <<shard-request-cache>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Default value?

@jrodewig
Copy link
Contributor Author

Thanks for your review @romseygeek.

@jrodewig jrodewig merged commit 7f1d05c into elastic:master Feb 24, 2020
@jrodewig jrodewig deleted the patch__msearch-path-parms branch February 24, 2020 12:41
jrodewig added a commit that referenced this pull request Feb 24, 2020
* Adds an example request to the top of the page.
* Relocates several parameters erroneously listed under "Request body"
to the appropriate "Query parameters" section.
* Updates the "Request body" section to better document the NDJSON
  structure of msearch requests.
jrodewig added a commit that referenced this pull request Feb 24, 2020
* Adds an example request to the top of the page.
* Relocates several parameters erroneously listed under "Request body"
to the appropriate "Query parameters" section.
* Updates the "Request body" section to better document the NDJSON
  structure of msearch requests.
@jrodewig
Copy link
Contributor Author

Backport commits

master 7f1d05c
7.x 98bcf06
7.6 a173418

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docs for msearch are incorrect
4 participants