Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect date nanos docs example #52249

Merged
merged 1 commit into from
Feb 12, 2020
Merged

Conversation

rjernst
Copy link
Member

@rjernst rjernst commented Feb 12, 2020

The example of how to access the nano value of a date_nanos field has
been broken since it was created. This commit fixes it to use the
correct scripting methods.

closes #51931

@rjernst rjernst added >docs General docs changes :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v8.0.0 v7.7.0 v7.6.1 labels Feb 12, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Scripting)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

@rjernst rjernst changed the title Fix incorrect date nanos docs exxample Fix incorrect date nanos docs example Feb 12, 2020
The example of how to access the nano value of a date_nanos field has
been broken since it was created. This commit fixes it to use the
correct scripting methods.

closes elastic#51931
Copy link
Contributor

@jdconrad jdconrad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing this

@rjernst rjernst merged commit f7c9897 into elastic:master Feb 12, 2020
@rjernst rjernst deleted the docs_cleanup6 branch February 12, 2020 23:54
rjernst added a commit that referenced this pull request Feb 12, 2020
The example of how to access the nano value of a date_nanos field has
been broken since it was created. This commit fixes it to use the
correct scripting methods.

closes #51931
rjernst added a commit that referenced this pull request Feb 12, 2020
The example of how to access the nano value of a date_nanos field has
been broken since it was created. This commit fixes it to use the
correct scripting methods.

closes #51931
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v7.6.1 v7.7.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[TEST] reference/mapping/types/date_nanos failing
4 participants