-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw better exception on wrong dynamic_templates
syntax
#51783
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
41b90b3
Fix issue #51486
feifeiiiiiiiiiii 62083e0
Fix style and add detail error information
feifeiiiiiiiiiii 8e4460b
Add illegal dynamic templates test
feifeiiiiiiiiiii 3537a18
Update server/src/main/java/org/elasticsearch/index/mapper/RootObject…
feifeiiiiiiiiiii fa73a21
Fix syntax error
feifeiiiiiiiiiii 5775ade
Update test exception message
feifeiiiiiiiiiii File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -168,6 +168,9 @@ protected boolean processField(RootObjectMapper.Builder builder, String fieldNam | |
} | ||
] | ||
*/ | ||
if (!(fieldNode instanceof List)) { | ||
throw new MapperParsingException("Dynamic template syntax error"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it would be good to provide some more information the user what went wrong. In this case it would be great to tell the user know that |
||
} | ||
List<?> tmplNodes = (List<?>) fieldNode; | ||
List<DynamicTemplate> templates = new ArrayList<>(); | ||
for (Object tmplNode : tmplNodes) { | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small style nit: can you use
((fieldNode instanceof List) == false)
instead? We prefer that kind of more verbose state to the negate operator for better readability throughout the codebase.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cbuescher ok I will fix for you suggest