Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing multiple plugins as a transaction #50924

Merged
merged 3 commits into from
Jan 14, 2020

Conversation

jasontedor
Copy link
Member

This commit allows the plugin installer to install multiple plugins in a single invocation. The installation will be treated as a transaction, so that all of the plugins are install successfully, or none of the plugins are installed.

Relates #50443

This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Plugins)

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, minor request on testing

@jasontedor
Copy link
Member Author

Thanks @rjernst. I have responded to your feedback.

@jasontedor
Copy link
Member Author

@elasticmachine update branch

Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I still think we should output something as each plugin is installed so it is not a black box to the end, but that can always be changed later.

@jasontedor
Copy link
Member Author

@elasticmachine run elasticsearch-ci/2

1 similar comment
@jasontedor
Copy link
Member Author

@elasticmachine run elasticsearch-ci/2

@jasontedor jasontedor merged commit 6b20a2c into elastic:master Jan 14, 2020
jasontedor added a commit that referenced this pull request Jan 14, 2020
This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
@jasontedor jasontedor deleted the multiple-plugins branch January 14, 2020 18:09
@jasontedor
Copy link
Member Author

I still think we should output something as each plugin is installed so it is not a black box to the end, but that can always be changed later.

See #51001 and let me know what you think?

SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
This commit allows the plugin installer to install multiple plugins in a
single invocation. The installation will be treated as a transaction, so
that all of the plugins are install successfully, or none of the plugins
are installed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants