Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: add remote info to the HLRC #50483

Merged
merged 1 commit into from
Dec 24, 2019
Merged

Backport: add remote info to the HLRC #50483

merged 1 commit into from
Dec 24, 2019

Commits on Dec 24, 2019

  1. Add remote info to the HLRC 

    The additional change to the original PR (elastic#49657), is that `org.elasticsearch.client.cluster.RemoteConnectionInfo` now parses the initial_connect_timeout field as a string instead of a TimeValue instance.

The reason that this is needed is because that the initial_connect_timeout field in the remote connection api is serialized for human consumption, but not for parsing purposes.
Therefore the HLRC can't parse it correctly (which caused test failures in CI, but not in the PR CI
:( ). The way this field is serialized needs to be changed in the remote connection api, but that is a breaking change. We should wait making this change until rest api versioning is introduced.

Co-Authored-By: j-bean <anton.shuvaev91@gmail.com>
    @martijnvg @AntonShuvaev
    martijnvg and AntonShuvaev committed Dec 24, 2019
    Configuration menu
    Copy the full SHA
    7d8d221 View commit details
    Browse the repository at this point in the history