Reduce the max depth of randomly generated interval queries #50317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romseygeek
added
>test
|
Pinging @elastic/es-search (:Search/Search) |
romseygeek
added a commit
that referenced
this pull request
Dec 19, 2019
We randomly generate intervals sources to test serialization and query generation in IntervalQueryBuilderTests. However, rarely we can generate a query that has too many nested disjunctions, resulting in query rewrites running afoul of the maximum boolean clause limit. This commit reduces the maximum depth of the randomly generated intervals source to make running into this limit much more unlikely.
SivagurunathanV
pushed a commit
to SivagurunathanV/elasticsearch
that referenced
this pull request
Jan 23, 2020
…50317) We randomly generate intervals sources to test serialization and query generation in IntervalQueryBuilderTests. However, rarely we can generate a query that has too many nested disjunctions, resulting in query rewrites running afoul of the maximum boolean clause limit. This commit reduces the maximum depth of the randomly generated intervals source to make running into this limit much more unlikely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We randomly generate intervals sources to test serialization and query generation
in
IntervalQueryBuilderTests. However, rarely we can generate a query that hastoo many nested disjunctions, resulting in query rewrites running afoul of the maximum
boolean clause limit.
This commit reduces the maximum depth of the randomly generated intervals source
to make running into this limit much more unlikely.