Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix accuracy metric #50310

Merged
merged 7 commits into from
Dec 20, 2019
Merged

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Dec 18, 2019

This PR fixes per-class accuracy calculation by taking into account per-class true negatives.

Additionally:

  • renames actual_classes to classes in accuracy metric for consistency with precision and recall metrics
  • makes Accuracy implemented using 'MulticlassConfusionMatrix`
  • makes use of SetOnce<> wrapper in classification metrics classes in order to increase code readability

Relates #48759

@przemekwitek przemekwitek force-pushed the fix_accuracy_metric branch 5 times, most recently from 3fbe5af to 2c08c19 Compare December 19, 2019 12:20
@przemekwitek przemekwitek removed the WIP label Dec 19, 2019
@przemekwitek przemekwitek marked this pull request as ready for review December 19, 2019 12:20
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek przemekwitek force-pushed the fix_accuracy_metric branch 3 times, most recently from f34a2e6 to 45ca9a7 Compare December 19, 2019 16:07
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM2

@przemekwitek przemekwitek merged commit e901f90 into elastic:master Dec 20, 2019
@przemekwitek przemekwitek deleted the fix_accuracy_metric branch December 20, 2019 13:00
przemekwitek added a commit to przemekwitek/elasticsearch that referenced this pull request Dec 20, 2019
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants