Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Introduce randomize_seed setting for regression and classification #49990

Conversation

dimitris-athanasiou
Copy link
Contributor

This adds a new randomize_seed for regression and classification.
When not explicitly set, the seed is randomly generated. One can
reuse the seed in a similar job in order to ensure the same docs
are picked for training.

This adds a new `randomize_seed` for regression and classification.
When not explicitly set, the seed is randomly generated. One can
reuse the seed in a similar job in order to ensure the same docs
are picked for training.
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@benwtrent benwtrent self-requested a review December 9, 2019 17:29
Copy link
Member

@benwtrent benwtrent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much simpler solution.

the default to CURRENT threw be a bit. Could you comment that it is used for the null case?

@dimitris-athanasiou
Copy link
Contributor Author

@benwtrent All other uses of CURRENT will be replaced with V_7_6_0 after I backport. The only CURRENT will stay where we get the params as a default, as if there's no version it will definitely be assigned CURRENT once created.

@dimitris-athanasiou dimitris-athanasiou merged commit 269425b into elastic:master Dec 10, 2019
@dimitris-athanasiou dimitris-athanasiou deleted the randomize-seed-setting-for-analyses-with-training-split branch December 10, 2019 08:23
dimitris-athanasiou added a commit that referenced this pull request Dec 10, 2019
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Dec 10, 2019
…ication (elastic#49990)

This adds a new `randomize_seed` for regression and classification.
When not explicitly set, the seed is randomly generated. One can
reuse the seed in a similar job in order to ensure the same docs
are picked for training.

Backport of elastic#49990
dimitris-athanasiou added a commit that referenced this pull request Dec 10, 2019
…ication (#49990) (#50023)

This adds a new `randomize_seed` for regression and classification.
When not explicitly set, the seed is randomly generated. One can
reuse the seed in a similar job in order to ensure the same docs
are picked for training.

Backport of #49990
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this pull request Dec 10, 2019
dimitris-athanasiou added a commit that referenced this pull request Dec 11, 2019
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
…on (elastic#49990)

This adds a new `randomize_seed` for regression and classification.
When not explicitly set, the seed is randomly generated. One can
reuse the seed in a similar job in order to ensure the same docs
are picked for training.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants