Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Transform][DOCS]rewrite client ip example to use continuous transform #49822

Merged
merged 3 commits into from
Dec 6, 2019

Conversation

hendrikmuhs
Copy link
Contributor

@hendrikmuhs hendrikmuhs commented Dec 4, 2019

adapt the transform example for suspicious client ips to use continuous transform.

Preview: http://elasticsearch_49822.docs-preview.app.elstc.co/guide/en/elasticsearch/reference/master/transform-examples.html

@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml/Transform)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs (>docs)

NOTE: Like other kibana sample data sets, the web log sample dataset contains
timestamps relative to when they are installed, including timestamps in the future.
The continuous {transform} will pickup the data points once they are in the past
(see delay). This enables you the see continuous mode in action, although we are
Copy link
Contributor

@lcawl lcawl Dec 5, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(see delay)

I don't feel like referring back to the 60 second delay is enough of an explanation. I suggest omitting this bit. Otherwise, it needs more explanation.

This enables you to see continuous mode in action...

IMO this sentence seems unnecessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed the remarks about delay. Let me know if I got this wrong.

Hendrik Muhs and others added 2 commits December 5, 2019 08:13
Co-Authored-By: Lisa Cawley <lcawley@elastic.co>
remove remarks about delay
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@hendrikmuhs hendrikmuhs merged commit 25474c6 into elastic:master Dec 6, 2019
hendrikmuhs pushed a commit that referenced this pull request Dec 6, 2019
#49822)

adapt the transform example for suspicious client ips to use continuous transform
hendrikmuhs pushed a commit that referenced this pull request Dec 6, 2019
#49822)

adapt the transform example for suspicious client ips to use continuous transform
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
elastic#49822)

adapt the transform example for suspicious client ips to use continuous transform
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants