Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run 180_locale_dependent_mapping only since 6.8.5 #49724

Merged
merged 2 commits into from
Dec 2, 2019
Merged

Run 180_locale_dependent_mapping only since 6.8.5 #49724

merged 2 commits into from
Dec 2, 2019

Conversation

pgomulka
Copy link
Contributor

closes #49719

@pgomulka pgomulka added the >test Issues or PRs that are addressing/adding tests label Nov 29, 2019
@pgomulka pgomulka self-assigned this Nov 29, 2019
dliappis
dliappis approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

dliappis
dliappis approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Given that we want to BWC test with >=6.8.5 yes this makes sense. I think you should update the PR title too.

@pgomulka pgomulka changed the title Run 180_locale_dependent_mapping only since 6.5 Run 180_locale_dependent_mapping only since 6.8.5 Nov 29, 2019
@pgomulka pgomulka merged commit d363b6b into elastic:7.x Dec 2, 2019
@jaymode jaymode mentioned this pull request Dec 3, 2019
Closed
@jaymode jaymode added the v7.6.0 label Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

Assignees

@pgomulka pgomulka

Labels
>test Issues or PRs that are addressing/adding tests v7.6.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pgomulka @dliappis @jaymode