Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 7.x] Fix iterate-from-1 bug in smart realm order #49614

Merged
merged 1 commit into from
Nov 27, 2019

Commits on Nov 27, 2019

  1. Fix iterate-from-1 bug in smart realm order

    The AuthenticationService has a feature to "smart order" the realm
    chain so that whicherver realm was the last one to successfully
    authenticate a given user will be tried first when that user tries to
    authenticate again.
    
    There was a bug where the building of this realm order would
    incorrectly drop the first realm from the default chain unless that
    realm was the "last successful" realm.
    
    In most cases this didn't cause problems because the first realm is
    the reserved realm and so it is unusual for a user that authenticated
    against a different realm to later need to authenticate against the
    resevered realm.
    
    This commit fixes that bug and adds relevant asserts and tests.
    
    Backport of: elastic#49473
    tvernum committed Nov 27, 2019
    Configuration menu
    Copy the full SHA
    477e5c7 View commit details
    Browse the repository at this point in the history