Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make AnalyticsProcessManager class more robust #49282

Merged
merged 1 commit into from
Nov 20, 2019
Merged

Make AnalyticsProcessManager class more robust #49282

merged 1 commit into from
Nov 20, 2019

Conversation

przemekwitek
Copy link
Contributor

@przemekwitek przemekwitek commented Nov 19, 2019 •
edited
Loading

Make AnalyticsProcessManager class more robust by fixing the following issues:
1. Add synchronization between runJob and stop that prevents swallowing stop() event in case stop() was called right after runJob
2. Prevent memory leak by removing processContext from the map whenever startProcess method returns false
3. Only store the first encountered failure reason for any given processContext
4. Write unit tests for AnalyticsProcessManager class

Relates #49095

@przemekwitek przemekwitek force-pushed the fix-model-output-twice-problem branch 2 times, most recently from ee17d64 to a500815 Compare November 19, 2019 09:04
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core (:ml)

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample-matrix

@przemekwitek
Copy link
Contributor Author

run elasticsearch-ci/packaging-sample-matrix

dimitris-athanasiou
dimitris-athanasiou approved these changes Nov 19, 2019
View reviewed changes
Copy link
Contributor

@dimitris-athanasiou dimitris-athanasiou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM This is great stuff!

@przemekwitek przemekwitek merged commit 6bcea53 into elastic:master Nov 20, 2019
@przemekwitek przemekwitek deleted the fix-model-output-twice-problem branch November 20, 2019 07:40
@przemekwitek przemekwitek mentioned this pull request Nov 20, 2019
Merged
przemekwitek added a commit that referenced this pull request Nov 20, 2019
@przemekwitek
[7.x] Make AnalyticsProcessManager class more robust (#49282) (#49356)
9c0ec7c
This was referenced Nov 27, 2019
Closed
Merged
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimitris-athanasiou dimitris-athanasiou dimitris-athanasiou approved these changes

Assignees
No one assigned
Labels
>bug :ml Machine learning v7.6.0 v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@przemekwitek @elasticmachine @dimitris-athanasiou @jakelandis