Retain exception fields in deserialization #49278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
v8.0.0
:Distributed/Reindex
|
Pinging @elastic/es-distributed (:Distributed/Reindex) |
|
@ywelsch @henningandersen This is a POC of how we could retain the information between deserializing a exception from reindexing and deserializing it for http response. |
server/src/main/java/org/elasticsearch/ElasticsearchException.java
Outdated
Show resolved
Hide resolved
| @@ -1182,4 +1226,18 @@ private static String toUnderscoreCase(String value) { | |||
| return sb.toString(); | |||
| } | |||
|
|
|||
| private static class XContentRetainingException extends ElasticsearchException { | |||
|
|
|||
| private final String fromXContentExceptionType; | |||
There was a problem hiding this comment.
Would be nice to also return this type from the static getExceptionName method.
server/src/test/java/org/elasticsearch/ElasticsearchExceptionTests.java
Outdated
Show resolved
Hide resolved
henningandersen
added a commit
to henningandersen/elasticsearch
that referenced
this pull request
Feb 25, 2020
Added xcontent serialization tests for ReindexTaskStateDoc Related to elastic#42612 Depends on elastic#49278 (todo)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ElasticsearchException
type,reason, andstacktraceareserialized to xcontent. However, when the xcontent is deserialized
these fields are lost. This PR adds a method that will optionally retain
these fields for usage when the exception is serialized a second time.