-
Notifications
You must be signed in to change notification settings - Fork 24.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mmap dim files in HybridDirectory #49272
Conversation
Pinging @elastic/es-distributed (:Distributed/Store) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This sounds good to me and I'd backport to 7.x, but I'm curious what @danielmitterdorfer thinks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I agree with @jpountz to backport to 7.x as well.
@jpountz @danielmitterdorfer Thanks for the reviews. Will add to 7.x as well. |
This change mmaps dim files in HybridDirectory to take advantage of off- heap BKD trees. This is based off of (#48509) via (https://issues.apache.org/jira/browse/LUCENE-8932).
This change mmaps dim files in HybridDirectory to take advantage of off-heap BKD trees. This is based off of (#48509) via (https://issues.apache.org/jira/browse/LUCENE-8932).
Should this be backported prior to 8.0?