Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add telemetry for flattened fields. #48972

Merged
merged 1 commit into from
Nov 14, 2019

Conversation

jtibshirani
Copy link
Contributor

Currently we just record the number of flattened fields defined in the mappings.

@jtibshirani jtibshirani added >enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v8.0.0 v7.6.0 labels Nov 12, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search (:Search/Mapping)

Currently we just record the number of flattened fields defined in the mappings.
@jtibshirani
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/packaging-sample-matrix

Copy link
Contributor

@mayya-sharipova mayya-sharipova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtibshirani Thanks, makes sense!


public FlattenedFeatureSetUsage(StreamInput input) throws IOException {
super(input);
this.fieldCount = input.getVersion().onOrAfter(Version.V_8_0_0) ? input.readInt() : 0;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume for 7.x the version would be changed to V_7_6_0 here and in writeTo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, that was my plan. Then I'll make an update on master to change to V_7_6_0 as well.

@jtibshirani jtibshirani merged commit 7344562 into elastic:master Nov 14, 2019
@jtibshirani jtibshirani deleted the flattened-field-telemetry branch November 14, 2019 15:27
jtibshirani added a commit that referenced this pull request Nov 18, 2019
Currently we just record the number of flattened fields defined in the mappings.
jtibshirani added a commit that referenced this pull request Nov 18, 2019
Follow-up to #48972, which was also backported to 7.6.
@@ -0,0 +1,41 @@
setup:
- skip:
version: " - 7.99.99"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jtibshirani Should this one be 7.5.99 now?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thanks @jpountz, I missed this when updating the serialization version.

jtibshirani added a commit that referenced this pull request Jan 10, 2020
It can be lowered to 7.5.99 now that the functionality was backported in #48972.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this pull request Jan 23, 2020
It can be lowered to 7.5.99 now that the functionality was backported in elastic#48972.
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Feb 21, 2020
Mpdreamz pushed a commit to elastic/elasticsearch-net that referenced this pull request Feb 21, 2020
github-actions bot pushed a commit to elastic/elasticsearch-net that referenced this pull request Feb 21, 2020
Mpdreamz pushed a commit to elastic/elasticsearch-net that referenced this pull request Feb 21, 2020
Relates: #4341, elastic/elasticsearch#48972

Co-authored-by: Russ Cam <russ.cam@elastic.co>
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Feb 23, 2020
@jakelandis jakelandis removed the v8.0.0 label Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement :Search Foundations/Mapping Index mappings, including merging and defining field types v7.6.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants