Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preflight check to dynamic mapping updates #48817

Merged

Commits on Nov 1, 2019

  1. Add preflight check to dynamic mapping updates

    Today if the primary discovers that an indexing request needs a mapping update
    then it will send it to the master for validation and processing. If, however,
    the put-mapping request is invalid then the master still processes it as a
    (no-op) cluster state update. When there are a large number of indexing
    operations that result in invalid mapping updates this can overwhelm the
    master.
    
    However, the primary already has a reasonably up-to-date mapping against which
    it can check the (approximate) validity of the put-mapping request before
    sending it to the master. For instance it is not possible to remove fields in a
    mapping update, so if the primary detects that a mapping update will exceed the
    fields limit then it can reject it itself and avoid bothering the master.
    
    This commit adds a pre-flight check to the mapping update path so that the
    primary can discard obviously-invalid put-mapping requests itself.
    
    Fixes elastic#35564
    DaveCTurner committed Nov 1, 2019
    Configuration menu
    Copy the full SHA
    1e3983c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    148206d View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2019

  1. Revert "Allow tests to override mapping validation"

    This reverts commit 148206d.
    DaveCTurner committed Nov 3, 2019
    Configuration menu
    Copy the full SHA
    006a8bf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4b66099 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2019

  1. Use constant

    DaveCTurner committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    82e6010 View commit details
    Browse the repository at this point in the history
  2. Add shard ID to message

    DaveCTurner committed Nov 4, 2019
    Configuration menu
    Copy the full SHA
    891e56a View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2019

  1. Configuration menu
    Copy the full SHA
    21f9fb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1fdfbd7 View commit details
    Browse the repository at this point in the history