Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the signature of vector script functions. #48604

Merged
merged 6 commits into from
Oct 29, 2019
Merged

Update the signature of vector script functions. #48604

merged 6 commits into from
Oct 29, 2019

Commits on Oct 29, 2019

  1. Update the signature of vector script functions.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    8c9722d View commit details
    Browse the repository at this point in the history

  2. Move the document field from the instance method to the constructor.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    62e9ced View commit details
    Browse the repository at this point in the history

  3. Combine fetching and validation of the doc vectors.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    ed95d9f View commit details
    Browse the repository at this point in the history

  4. Give a descriptive error message when the 'field' type is invalid.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    c6f3f6d View commit details
    Browse the repository at this point in the history

  5. Fix a syntax error in 40_sparse_vector_special_cases.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    6a58e3f View commit details
    Browse the repository at this point in the history

  6. In tests, make sure to assert warnings after each function invocation.

    @jtibshirani
    jtibshirani committed Oct 29, 2019
    Configuration menu
    Copy the full SHA
    51ac60b View commit details
    Browse the repository at this point in the history