Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup Concurrent RepositoryData Loading #48329

Merged
merged 5 commits into from
Oct 23, 2019

Commits on Oct 22, 2019

  1. Cleanup Concurrent RepositoryData Loading

    The loading of `RepositoryData` is not an atomic operation.
    It uses a list + get combination of calls.
    This lead to accidentally returning an empty repository data
    for generations >=0 which can never not exist unless the repository
    is corrupted.
    In the test elastic#48122 (and other SLM tests) there was a low chance of
    running into this concurrent modification scenario and the repository
    actually moving two index generations between listing out the
    index-N and loading the latest version of it. Since we only keep
    two index-N around at a time this lead to unexpectedly absent
    snapshots in status APIs.
    Fixing the behavior to be more resilient is non-trivial but in the works.
    For now I think we should simply throw in this scenario. This will also
    help prevent corruption in the unlikely event but possible of running into this
    issue in a snapshot create or delete operation on master failover on a
    repository like S3 which doesn't have the "no overwrites" protection on
    writing a new index-N.
    
    Fixes elastic#48122
    original-brownbear committed Oct 22, 2019
    Configuration menu
    Copy the full SHA
    43c98cf View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4171652 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2019

  1. Configuration menu
    Copy the full SHA
    3c5d0d9 View commit details
    Browse the repository at this point in the history
  2. shorter

    original-brownbear committed Oct 23, 2019
    Configuration menu
    Copy the full SHA
    6692fd9 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2524515 View commit details
    Browse the repository at this point in the history