Fix BulkProcessor deadlock when bulk requests fail (#47599) #48013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pinging @elastic/es-core-features (:Core/Features/Java High Level REST Client) |
|
closing in favor of #48697 Thanks again @suxinglee for finding this issue as well as the test case. I described that PR's description why I chose to use separate schedulers instead on increasing the number of the single scheduler. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #47599 we known that if the BulkProcessor results in failed bulk requests, they will be retried via the RetryHandler. In versions of Elasticsearch prior to 7.3.0 this can result in a deadlock.
It seems that there is a similar deadlock problem in the Elasticsearch version after 7.3.0.
Different from #46790, here we first execute the
Flushlogic ,then the shared thread poolSchedulercannot execute the retry logic, so the flush logic cannot be ended. Causes the ReentrantLock cannot be obtained by the user thread ininternalAddmethod.