Make StartReindexJobAction a non-master action #45217
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TransportStartReindexJobAction is currently a master action. Reindexing only needs access to the cluster state to perform some validations. Prior to persistent reindexing we used a normal data node to perform these validations. There is not reason that these validations need a perfectly update to date view of the cluster state. The commit changes the action to be a normal transport action. Relates to elastic#42612.
Tim-Brooks
added
>non-issue
v8.0.0
:Distributed/Reindex
|
Pinging @elastic/es-distributed |
henningandersen
approved these changes
Aug 6, 2019
| @Override | ||
| protected void masterOperation(Task task, StartReindexJobAction.Request request, ClusterState state, | ||
| ActionListener<StartReindexJobAction.Response> listener) { | ||
| protected void doExecute(Task task, StartReindexJobAction.Request request, ActionListener<StartReindexJobAction.Response> listener) { | ||
| // TODO: If the connection is lost to the master, this action might be retried creating two tasks. |
There was a problem hiding this comment.
Is this todo still accurate? I think this works OK now, since the REST action will call this on local node and thus there can be no retries?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransportStartReindexJobAction is currently a master action. Reindexing
only needs access to the cluster state to perform some validations.
Prior to persistent reindexing we used a normal data node to perform
these validations. There is no reason that these validations need a
perfectly update-to-date view of the cluster state. The commit changes
the action to be a normal transport action.
Relates to #42612.