Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Replace _meta with metadata for snapshot APIs. #44596

Merged
merged 1 commit into from
Jul 19, 2019
Merged

[DOCS] Replace _meta with metadata for snapshot APIs. #44596

merged 1 commit into from
Jul 19, 2019

Conversation

jrodewig
Copy link
Contributor

@jrodewig jrodewig commented Jul 18, 2019

#41281 added custom metadata parameter to the snapshots APIs.

During iteration, the parameter name was changed from _meta to metadata but the documentation wasn't updated. This corrects the documentation to use the metadata parameter name.

Resolves #44195

#41281 added custom metadata parameter to
snapshots. During review, the parameter name was changed from '_meta' to
'metadata' but the documentation wasn't updated. This corrects the
documentation to use the 'metadata' name.
@jrodewig jrodewig added :Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes labels Jul 18, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-docs

Copy link
Member

@original-brownbear original-brownbear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @jrodewig !

@jrodewig jrodewig merged commit 506de3b into elastic:master Jul 19, 2019
@jrodewig jrodewig deleted the fix-snapshot-metadata-field branch July 19, 2019 12:40
jrodewig added a commit that referenced this pull request Jul 19, 2019
#41281 added custom metadata parameter to
snapshots. During review, the parameter name was changed from '_meta' to
'metadata,' but the documentation wasn't updated. This corrects the
documentation to use the 'metadata' name.
jrodewig added a commit that referenced this pull request Jul 19, 2019
#41281 added custom metadata parameter to
snapshots. During review, the parameter name was changed from '_meta' to
'metadata,' but the documentation wasn't updated. This corrects the
documentation to use the 'metadata' name.
@jpountz jpountz added v7.3.0 and removed v7.3.1 labels Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Distributed/Snapshot/Restore Anything directly related to the `_snapshot/*` APIs >docs General docs changes v7.3.0 v7.4.0 v8.0.0-alpha1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Replace _meta with metadata for snapshot APIs
5 participants