Deprecation info for joda-java migration on 7.x #42659
Conversation
|
Pinging @elastic/es-core-infra |
| } | ||
|
|
||
| @SuppressWarnings("unchecked") | ||
| static DeprecationIssue checkFormatOnPipeline(ClusterState state) { |
There was a problem hiding this comment.
any ideas how to check that pipeline was created in 6.x?
There was a problem hiding this comment.
I don't think it's possible to check when the pipeline was created, unfortunately. However, it's much easier to update pipelines to use the 8 prefix (compared to mappings) so I don't think it matters as much here.
There was a problem hiding this comment.
@gwbrown agree, it is easier to fix them (just a PUT with a fixed pipeline). Should we then alert for all pipelines without the 8prefix, suspecting that it was not updated?
Or should we not alert at all and let user find this on their own?
There was a problem hiding this comment.
Users in 7 are not required to prefix their format with 8.
If we just alert without checking the version, and someone changes their pattern from Y to y it will still alert from him. Both are deprecated in 6.x. (Y->y and y->u)
I wonder if the best way here is not alert about pipelines at all in 7x
There was a problem hiding this comment.
we discussed this offline and decided to remove pipelines' checks in 7.x. There would be no easy way to fix these deprecation warnings and this is likely to generate a lot of false positives.
|
@elasticmachine run elasticsearch-ci/bwc |
|
@elasticmachine update branch |
|
@elasticmachine ok to test |
| PutPipelineRequest pipelineRequest = new PutPipelineRequest("testingestpipeline", | ||
| new BytesArray("{\n" + | ||
| " \"description\": \"Pipeline with date and date_index_name processor\",\n" + | ||
| " \"processors\": [\n" + |
There was a problem hiding this comment.
Maybe add a date processor to this that doesn't use deprecated formats to help make this more resistant to regressions.
…e was created, and therefore to make sure the format is depracated or not
Some clusters might have been already migrated to version 7 without being warned about the joda-java migration changes.
Deprecation api on that version will give them guidance on what patterns need to be changed.
relates. This change is using the same logic like in 6.8 that is: verifying the pattern is from the incompatible set ('y'-Y', 'C', 'Z' etc), not from predifined set, not prefixed with 8. AND was also created in 6.x. Mappings created in 7.x are considered migrated and should not generate warnings
There is no pipeline check (present on 6.8) as it is impossible to verify when the pipeline was created, and therefore to make sure the format is depracated or not
Some clusters might have been already migrated to version 7 without being warned about the joda-java migration changes.
Deprecation api on that version will give them guidance on what patterns need to be changed.
relates. This change is using the same logic like in 6.x that is: verifying the pattern is from the incompatible set ('y'-Y', 'C', 'Z' etc), not from predifined set, not prefixed with 8. AND was also created in 6.x. Mappings created in 7.x are considered migrated and should not generate warnings
#42010